Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-09-11 #27120

Closed
31 tasks done
OSBotify opened this issue Sep 11, 2023 · 11 comments
Closed
31 tasks done

Deploy Checklist: New Expensify 2023-09-11 #27120

OSBotify opened this issue Sep 11, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 11, 2023

Release Version: 1.3.67-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@roryabraham roryabraham added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 11, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.67-0 🚀

@mvtglobally mvtglobally added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Sep 11, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.67-0 🚀

@Julesssss
Copy link
Contributor

I checked off #26381 as it is a minor notification logo colour change

@Julesssss
Copy link
Contributor

#26953 is not a blocker, the fix is already on prod so I removed the label and checked it off.

@Julesssss
Copy link
Contributor

Verified and checked off #26980 as it's a dev-only issue.

@mountiny
Copy link
Contributor

Closing #27157, not repro

@arosiclair
Copy link
Contributor

#27160 is reproducible on prod. Checked it off

@cristipaval
Copy link
Contributor

cristipaval commented Sep 11, 2023

Checked off #27145 as the PR that introduced the regression was reverted and I tested and can confirm that the blocker is now fixed.

@kavimuru
Copy link

kavimuru commented Sep 11, 2023

@AndrewGable Regression only 4 steps to go
PR #26856 - Desktop slot is blocked with this issue #25790
Web is failing with this issue #26852 for these 2 deeplinks https://staging.new.expensify.com/enable-payments and https://staging.new.expensify.com/sbe

@kavimuru
Copy link

Regression completed.
PR #26856 - Desktop slot is blocked with this issue #25790 which is known
Web failing with known issue #26021 - checking it off

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

10 participants