Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Web - Closing the manual request currency selector opens the distance request tab. #27157

Closed
1 of 6 tasks
kbecciv opened this issue Sep 11, 2023 · 4 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Sep 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click the FAB button
  2. Click either Request money or Split bill
  3. Open the currency selector page by clicking on the currently selected currency
  4. Select any currency

Expected Result:

You should be sent back to the manual request money tab

Actual Result:

The distance request tab is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.67.2
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-11.at.16.16.21.mov

Expensify/Expensify Issue URL:
Issue reported by: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694442122791199

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment Needs Reproduction Reproducible steps needed labels Sep 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@joh42
Copy link
Contributor

joh42 commented Sep 11, 2023

After clearing cookies it's the scan receipts tab that is opened:

Screen.Recording.2023-09-11.at.16.48.13.mov

@joh42
Copy link
Contributor

joh42 commented Sep 11, 2023

Okay sorry about this, I think you can disregard this issue. It seems like I had some problems with react-navigation/native. Removing the node_modules folder and reinstalling from scratch fixed it

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants