Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web -Tooltip for user in group is offcenter and displayed over report #21105

Closed
1 of 6 tasks
kbecciv opened this issue Jun 20, 2023 · 7 comments
Closed
1 of 6 tasks

Web -Tooltip for user in group is offcenter and displayed over report #21105

kbecciv opened this issue Jun 20, 2023 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Jun 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Scroll to group report which has partial name or email in end
  3. Hover on 3 dots

Expected Result:

App should display tooltip over 3 dots in LHN for group users

Actual Result:

App displays tooltip over report for group users in end

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-3

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

tooltip.not.positioned.right.1.mp4
Recording.5040.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686647368251889

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv kbecciv changed the title Tooltip for user in group is offcenter and displayed over report Web -Tooltip for user in group is offcenter and displayed over report Jun 20, 2023
@alitoshmatov
Copy link
Contributor

alitoshmatov commented Jun 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web -Tooltip for user in group is offcenter and displayed over report

What is the root cause of that problem?

We are not passing shiftHorizontal prop down to tooltip in UserDetailsTooltip which is responsible for preventing this kind of issue, where child element is not visible and its center is outside of parent element. We are passing shiftHorizontal to UserDetailsTooltip

shiftHorizontal={() => this.getTooltipShiftX(index)}

What changes do you think we should make in order to solve the problem?

We should pass props.shiftHorizontal down to Tooltip component here:

return <Tooltip renderTooltipContent={renderTooltipContent}>{props.children}</Tooltip>;

  shiftHorizontal={props.shiftHorizontal}

What alternative solutions did you explore? (Optional)

@jeet-dhandha
Copy link
Contributor

@alitoshmatov Your proposal should fix this issue too.

ISSUE: #21100

@alitoshmatov
Copy link
Contributor

@jeet-dhandha You are right it should fix that issue

@melvin-bot melvin-bot bot added the Overdue label Jun 22, 2023
@tjferriss
Copy link
Contributor

I tried to recreate the issue. My tooltips hover over the name as intended. Does this only happen with extra long names/emails? If so, @kbecciv can you update the OP?

Screenshot 2023-06-23 at 09 51 27

@melvin-bot melvin-bot bot removed the Overdue label Jun 23, 2023
@tjferriss tjferriss added the Needs Reproduction Reproducible steps needed label Jun 23, 2023
@alitoshmatov
Copy link
Contributor

alitoshmatov commented Jun 26, 2023

Screenshot 2023-06-26 at 11 20 27 PM

I think it is still reproducable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

4 participants