Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip of LHN elements is WAY OFF for longer emails #21737

Closed
1 of 6 tasks
kavimuru opened this issue Jun 27, 2023 · 6 comments
Closed
1 of 6 tasks

tooltip of LHN elements is WAY OFF for longer emails #21737

kavimuru opened this issue Jun 27, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. open any chat
  2. scroll through LHN to find longer emails
  3. hover over the names and observe the tooltip

Expected Result:

tootltip is rightwards in the main chat

Actual Result:

tootltip should be right above the element

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.33-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-06-17.13-36-08-747.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686989358411139

View all open jobs on GitHub
Screenshot (374)

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@allroundexperts
Copy link
Contributor

allroundexperts commented Jun 28, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip of LHN is not showing up correctly

What is the root cause of that problem?

The root cause of the issue is that the text is rendered inside DisplayNames component as inline. This causes the DisplayNames to take up the full length of the page. As such, the tooltip renders at the end of the page.

What changes do you think we should make in order to solve the problem?

We need to add the following style here on Web and Desktop only:

display: 'block',
textOverflow: 'ellipsis',

What alternative solutions did you explore? (Optional)

None

@bernhardoj
Copy link
Contributor

Dupe of #21105

@allroundexperts
Copy link
Contributor

@dylanexpensify I think this should not be closed. #21105 was closed because the issue wasn't reproducible. The issue was never solved there as far as I can see.

@kavimuru
Copy link
Author

kavimuru commented Jul 4, 2023

@dylanexpensify This issue is still reproducible and reported in channel.
https://expensify.slack.com/archives/C049HHMV9SM/p1688368904317509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants