[HOLD for payment 2023-07-26] [$1000] Web - The tooltip end is broken for users with long names on details page of group chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome and login with User A
2. Create a group with multiple users
3. Click on details page
4. Login with any one user on another web chrome that you have create a group with
5. Change the display name of the user and replace it with a long name (max character)
6. Go to User A and hover over the username of the user on the details page and notice that the pointer of the tooltip is broken (not centered)

Expected Result:

The pointer of the tooltip should be centered

Actual Result:

The pointer of the tooltip is off-center for users with long names on details page of group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.2

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-13_11.24.23.1.mp4

Recording.2662.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686635011685439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01813ef7a0589a7c4b
• Upwork Job ID: 1676961079120977920
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[johncschuster]

Looks like @alitoshmatov has a proposal in the above-linked GH that should fix this as well.

[johncschuster]

I'm going to downgrade this to Weekly while we wait on the other issue to get resolved.

[alitoshmatov]

@johncschuster Looks like the other issue is closed, I think you should proceed with this one. Just in case, I am going post my proposal here as well

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Tooltip pointer is not pointing to the center of the text

What is the root cause of that problem?

We are not passing shiftHorizontal prop down to tooltip in UserDetailsTooltip which is responsible for preventing this kind of issue, where child element is not visible and its center is outside of parent element. We are passing shiftHorizontal to UserDetailsTooltip

App/src/components/DisplayNames/index.js

Line 100 in ddc19e0

shiftHorizontal={() => this.getTooltipShiftX(index)}

What changes do you think we should make in order to solve the problem?

We should pass props.shiftHorizontal down to Tooltip component here:

App/src/components/UserDetailsTooltip/index.js

Line 42 in e6c2704

return <Tooltip renderTooltipContent={renderTooltipContent}>{props.children}</Tooltip>;

  shiftHorizontal={props.shiftHorizontal}

Result:

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01813ef7a0589a7c4b

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[Sandeep7409]

First name and Last name allow max 50 characters and tooltip shows all 50 characters. I don't understand what is the meaning of "the end of the tooltip is broken". Please include some actual and expected result in issue description to make it clear.

[melvin-bot]

📣 @Sandeep7409! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Sandeep7409]

Contributor details
Your Expensify account email: sandeep.patel25@hotmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01885cd3495b066b3f

[cead22]

Not overdue. Working on payments

[johncschuster]

Are we working on payment? It seems like the behavior isn't resolved yet, right?

[alitoshmatov]

@johncschuster Similar issue did come up, but it is not related to this and has a different root cause

[johncschuster]

@alitoshmatov can you share that similar issue here?

[alitoshmatov]

@johncschuster This one #23784

[spcheema]

@cead22 @johncschuster Actually linked that issue thought it's related. Apologies for confusion and causing delay in you payout @alitoshmatov

[melvin-bot]

@cead22, @johncschuster, @alitoshmatov, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Thanks for surfacing that, @alitoshmatov! I'll get payments issued now.

[johncschuster]

Summary:

External issue reporter - @priya-zha = $250 (paid through Upwork)
Contributor that fixed the issue - @alitoshmatov - $1500 (paid through Upwork)
Contributor+ that helped on the issue and/or PR - @aimane-chnaif - $1500 (will request payment through NewDot)

cc @JmillsExpensify

[aimane-chnaif]

@johncschuster I am still using upwork

[johncschuster]

Ah, thanks for calling that out! I'll get payment issued via Upwork for you then.

[johncschuster]

I have issued payment to @aimane-chnaif via Upwork.

@priya-zha, I've sent the invite to you via Upwork. Can you accept that so I can issue payment?

[priya-zha]

Thanks.. Accepted.

[johncschuster]

Thank you! I've issued payment to @priya-zha.

[melvin-bot]

@cead22, @johncschuster, @alitoshmatov, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cead22, @johncschuster, @alitoshmatov, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[cead22]

On hold for payment and not overdue

[johncschuster]

Uhh... I don't think that's right. I issued payment, and it looks like I totally forgot to close the issue. 🤦

Closing!