[HOLD for payment 2023-04-24] [HOLD for payment 2023-04-20] [$2000] Tapping on notification /switching chats does not take to correct chat / closing immediately

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Scenario 1:

1. Receive a notification from another account for any message
2. Tap on the notification

Scenario 2:

1. Open a chat
2. Switch to another chat

Expected Result:

User is taken to correct chat when tapping on notification and should not and go back to LHN
When switching chat rooms, should load chat and should not close

Actual Result:

Some times chat does not open on tapping notification or it opened the chat ever so slightly then closed it immediately, going back to the LHN

When switching the chat it does not load or returning back to LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.80
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677683692081849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a33e508f0b3ba861
• Upwork Job ID: 1635427381211086848
• Last Price Increase: 2023-03-20

[MelvinBot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[davidcardoza]

Sending out to external since this was reported by an internal employee and verified by others as reproducible in the Slack thread.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a33e508f0b3ba861

[MelvinBot]

Current assignee @davidcardoza is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@davidcardoza @marcaaron I'm unable to reproduce this.

Kooha-2023-03-15-18-17-25.mp4

[s77rt]

Not overdue. I think this need reproduction.
Also no proposals yet...

[s77rt]

Not overdue. Same ^

[s77rt]

• The PR that introduced the bug has been identified:
  1. Migrate to Airship v15.2.0 #16360
  2. Hide notifications for the currently open report #15858
• The offending PR has been commented on:
  1. Migrate to Airship v15.2.0 #16360 (comment)
  2. Hide notifications for the currently open report #15858 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1681358436985689

---

Regression Test Proposal

1. User 1: Open App
2. User 1: Open chat with any user except User 2 (e.g. open chat with Concierge)
3. User 1: Kill the App
4. User 2: Open App
5. User 2: Open chat with User 1
6. User 2: Send a message
7. User 1: Verify you get a notification
8. User 1: Tap the notification
9. User 1: Verify you are brought to the correct chat with User 2

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Import correct CONST to unbreak notifications #17352

If no regressions arise, payment will be issued on 2023-04-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[s77rt]

Checklist provided already here #15758 (comment)

[MelvinBot]

@davidcardoza, @s77rt, @marcaaron Eep! 4 days overdue now. Issues have feelings too...

[s77rt]

@davidcardoza @marcaaron can you please handle the checklist

[marcaaron]

Checked everything off. Looks good so I think we just need an issue to create the regression test.

[marcaaron]

Ok created that so we are good. Thanks @s77rt

[marcaaron]

Looks like we are just waiting for payment on this one 🙏 cc @davidcardoza

[davidcardoza]

@s77rt payment sent

[s77rt]

@davidcardoza Thank you! However I'm not sure If the payment should be $2000 or $1000. I asked on Slack https://expensify.slack.com/archives/C02NK2DQWUX/p1682974144300749

[s77rt]

@davidcardoza So it seems to be $1000, can you please send another offer that amount

[davidcardoza]

Hm, not sure why the title is $2000. Either way, the offer was modified and sent.

[davidcardoza]

This can be closed.