[HOLD for payment 2023-04-20] Push notification background updates don't seem to be working

[arosiclair]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Receive some NewDot messages
2. Check logs for handling Airship notifications for those messages (eg: logsearch)

Expected Result:

We should have at least a few results for some of these messages

Actual Result:

We have no logs for Airship messages since 4/2 at least (my logs)

Workaround:

No workaround necessary, but this being broken is a subpar UX.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.2.97-2
Reproducible in staging?: Yes
Reproducible in production?: Not sure
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C04E99DVBTP/p1681152024687099?thread_ts=1680980284.168379&cid=C04E99DVBTP

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017276e0552aa2476d
• Upwork Job ID: 1645534952654491648
• Last Price Increase: 2023-04-10

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~017276e0552aa2476d

[MelvinBot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[arosiclair]

Internal access only for logs so removing C+

[arosiclair]

Okay this was caused by the Airship 15 migration. I missed migrating the event listener callbacks. Specifically, they changed the shape of the notification object we receive. So we weren't getting the payload properly resulting in this error:

[warn] [PushNotification] Notification has null or undefined payload, not executing any callback

[dylanexpensify]

@arosiclair anything needed here on my end? From the looks of it I don't think so, but wanna make sure I'm not missing anything :)

[arosiclair]

Nope you should be good! Fixes for this'll hit prod very soon

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Airship PushReceived handler #17251

If no regressions arise, payment will be issued on 2023-04-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR: Migrate to Airship v15.2.0 #16360
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Migrate to Airship v15.2.0 #16360 (comment)
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1681358436985689
• [@dylanexpensify] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arosiclair]

Let's see where the discussion goes before proposing regression test steps

[dylanexpensify]

@arosiclair any updates on where we're at with Regression test?

[arosiclair]

I think we're not gonna add any new regression steps for this. If we do, it would be for this related bug on notification click through instead. However, it looks like we already have regression test steps for that here.

Continuing discussion here

[dylanexpensify]

Cool cool, no payments here are due, right?

[arosiclair]

Yup no payment. Everything was internal

[dylanexpensify]

Not overdue, any updates @arosiclair?

[arosiclair]

Yeah we do have existing regression steps for notification click through here so no need to add more.

Looks like this bug made it into production because we already had an open bug for it. So next time we just have to be more diligent about labeling it as a deploy blocker when it hits staging. With that said, I think this is all set!