feat: create comment-issue-due-date helper #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danadajian
reviewed
Sep 28, 2023
k-borley
force-pushed
the
comment-issue-due-date
branch
from
fb39c1f
to
1f18f04
Compare
danadajian
reviewed
Oct 2, 2023
|
|
||
| jobs: | ||
| test: | ||
| if: contains(fromJSON('["Priority: Critical", "Priority: High", "Priority: Medium", "Priority: Low"]'), github.event.label.name) |
There was a problem hiding this comment.
I think it would be more intuitive to run this helper for each label and have it do nothing in the case the label doesn't match
| import { PRIORITY_1, PRIORITY_2, PRIORITY_3, PRIORITY_4 } from '../constants'; | ||
|
|
||
| export class CreateIssueDuedateComment extends HelperInputs { | ||
| label!: typeof PRIORITY_1 | typeof PRIORITY_2 | typeof PRIORITY_3 | typeof PRIORITY_4; |
There was a problem hiding this comment.
Suggested change
| label!: typeof PRIORITY_1 | typeof PRIORITY_2 | typeof PRIORITY_3 | typeof PRIORITY_4; | |
| label!: keyof typeof daysOpenBasedOnPriority |
Comment on lines
+23
to
+32
| export type PriorityDueDateMapping = { | ||
| [key: string]: number; | ||
| }; | ||
|
|
||
| const daysOpenBasedOnPriority: PriorityDueDateMapping = { | ||
| [PRIORITY_1]: 2, | ||
| [PRIORITY_2]: 14, | ||
| [PRIORITY_3]: 45, | ||
| [PRIORITY_4]: 90 | ||
| }; |
There was a problem hiding this comment.
Suggested change
| export type PriorityDueDateMapping = { | |
| [key: string]: number; | |
| }; | |
| const daysOpenBasedOnPriority: PriorityDueDateMapping = { | |
| [PRIORITY_1]: 2, | |
| [PRIORITY_2]: 14, | |
| [PRIORITY_3]: 45, | |
| [PRIORITY_4]: 90 | |
| }; | |
| const daysOpenBasedOnPriority = { | |
| [PRIORITY_1]: 2, | |
| [PRIORITY_2]: 14, | |
| [PRIORITY_3]: 45, | |
| [PRIORITY_4]: 90 | |
| } as const; |
| jest.spyOn(Date, 'now').mockImplementation(() => new Date('2023-09-26T10:00:00Z').getTime()); | ||
|
|
||
| describe('commentIssueDueDate', () => { | ||
| it('should add due dates correctly based on priority label', async () => { |
There was a problem hiding this comment.
We should add a test for if an invalid label is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This issue is due on Mon Dec 25 2023). The due date is based on SLA guidelines (see table).