Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manage-issue-due-dates): create helper for managing issue due dates #442

Merged
merged 21 commits into from
Oct 4, 2023
Merged

feat(manage-issue-due-dates): create helper for managing issue due dates #442

merged 21 commits into from
Oct 4, 2023

Conversation

k-borley
Copy link
Contributor

@k-borley k-borley commented Sep 26, 2023 •
edited
Loading

📝 Description

  • Adds a helper that will add an 'overdue' label to issues that have a priority label (critical, high, med, low) and are overdue according to SLA Guidelines (see table). Also adds a 'due soon' label to issues that will become overdue in 7 days.
Priority Days Before Resolution
Critical 2
High 14
Medium 45
Low 90
  • The name of the labels default to Overdue and Due Soon for the labels added, and Priority: Critical, Priority: High, Priority: Medium, and Priority: Low for priority labels. All are customizable. The threshold for when to add the "due soon" label is also customizable.

@k-borley k-borley requested a review from a team as a code owner September 26, 2023 19:37
danadajian
danadajian previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@danadajian danadajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper seems like it could be absorbed into #443

@k-borley
Copy link
Contributor Author

This helper seems like it could be absorbed into #443

Yes, they were combined initially, but you told me it would be better to introduce one at a time so I split them into two PRs

@danadajian
Copy link
Contributor

Sorry, I'm talking about absorbing this helper into the other helper, not just the PR's themselves

@k-borley
Copy link
Contributor Author

Sorry, I'm talking about absorbing this helper into the other helper, not just the PR's themselves

Ah okay, I'm not sure how that would work since one helper runs when a label is first added to a specific issue and the other one runs daily and checks all issues

@danadajian
Copy link
Contributor

Sorry, I'm talking about absorbing this helper into the other helper, not just the PR's themselves

Ah okay, I'm not sure how that would work since one helper runs when a label is first added to a specific issue and the other one runs daily and checks all issues

Couldn't a single helper determine when a PR is overdue and also add due date comments?

@k-borley k-borley changed the title feat: create add-overdue-issue-label helper feat: create manage-issue-due-date helper Oct 2, 2023
danadajian
danadajian reviewed Oct 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
test/helpers/manage-issue-due-dates.test.ts Show resolved Hide resolved
danadajian
danadajian reviewed Oct 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/utils/add-due-date-comment.ts Outdated Show resolved Hide resolved
src/utils/add-overdue-labels.ts Outdated Show resolved Hide resolved
danadajian
danadajian reviewed Oct 4, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
src/utils/add-due-date-comment.ts Outdated Show resolved Hide resolved
src/utils/add-due-date-comment.ts Outdated Show resolved Hide resolved
src/helpers/manage-issue-due-dates.ts Outdated Show resolved Hide resolved
k-borley and others added 11 commits October 4, 2023 08:00
@k-borley
fix: next batch of review comments
5d07b77
@k-borley
fix: no custom overdue labels
fb747fa
@k-borley
fix: no custom priority labels
fa45368
@dependabot @danadajian
chore(deps): bump axios from 1.5.0 to 1.5.1 (ExpediaGroup#448)
2414a3b 
* chore(deps): bump axios from 1.5.0 to 1.5.1

Bumps [axios](https://github.com/axios/axios) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: committing generated dist

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot @danadajian
chore(deps-dev): bump @types/js-yaml from 4.0.5 to 4.0.6 (ExpediaGrou…
c37555d 
…p#447)

Bumps [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml)

---
updated-dependencies:
- dependency-name: "@types/js-yaml"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @danadajian
chore(deps-dev): bump @typescript-eslint/eslint-plugin (ExpediaGroup#450
3960bd4 
)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.7.2 to 6.7.4.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.4/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @danadajian
chore(deps-dev): bump @types/node from 20.6.5 to 20.8.2 (ExpediaGroup…
087da08 
…#449)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.6.5 to 20.8.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @danadajian
chore(deps): bump @octokit/rest from 20.0.1 to 20.0.2 (ExpediaGroup#444)
52b131e 
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 20.0.1 to 20.0.2.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v20.0.1...v20.0.2)

---
updated-dependencies:
- dependency-name: "@octokit/rest"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@danadajian
cleanup logic a bit
ff7c854
@danadajian
resolve conflicts
53dfa31
@danadajian
fix warning log
a4ddc62
@danadajian danadajian changed the title feat: create manage-issue-due-date helper feat(manage-issue-due-date): create helper for managing issue due dates Oct 4, 2023
@danadajian danadajian changed the title feat(manage-issue-due-date): create helper for managing issue due dates feat(manage-issue-due-dates): create helper for managing issue due dates Oct 4, 2023
@danadajian danadajian dismissed their stale review October 4, 2023 17:01

Changes addressed

@danadajian danadajian enabled auto-merge (squash) October 4, 2023 19:13
@danadajian danadajian merged commit 80b9b4e into ExpediaGroup:main Oct 4, 2023
3 checks passed
@danadajian
Copy link
Contributor

🎉 This PR is included in version 1.45.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@k-borley k-borley deleted the add-overdue-issue-label branch October 4, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danadajian danadajian danadajian approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-borley @danadajian