Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bmff exception; Bump Conan version #2375

Conversation

postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev added this to the v0.27.6 milestone Oct 8, 2022
@postscript-dev postscript-dev self-assigned this Oct 8, 2022
@postscript-dev postscript-dev marked this pull request as draft October 8, 2022 15:06
@hassec
Copy link
Member

hassec commented Oct 17, 2022

@postscript-dev Did you mean to open this against main? Shouldn't this target the maintenance branch?

@postscript-dev postscript-dev changed the base branch from main to 0.27-maintenance October 18, 2022 08:25
@postscript-dev
Copy link
Collaborator Author

@hassec

Did you mean to open this against main? Shouldn't this target the maintenance branch?

Thanks for pointing that out. I was short of time so set the PR to draft and planned to investigate later.

@postscript-dev postscript-dev marked this pull request as ready for review October 18, 2022 10:38
@postscript-dev postscript-dev merged commit 4f1d091 into Exiv2:0.27-maintenance Oct 18, 2022
@postscript-dev postscript-dev deleted the fix_bmff_exception_0.27-maintenance branch October 18, 2022 10:42
antermin pushed a commit to antermin/exiv2 that referenced this pull request Mar 16, 2023
- This is a partial backport of Exiv2#2364. The new exceptions in `::setExifData()`/`::setIptcData()`/`::setXmpData()` are not included as they could change the control flow of the maintenance branch for the user.
- Conan change is a backport of Exiv2#2361
- Closes Exiv2#2350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong error message?
3 participants