Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump conan version to 1.52.0 #2361

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

kevinbackhouse
Copy link
Collaborator

I'm hoping that this change will fix the build failures that I'm getting in #2353.

@kevinbackhouse kevinbackhouse added Conan Handle external dependencies via Conan CI Issues related with CI jobs build labels Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #2361 (e97dc16) into main (d2253c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2361   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files         119      119           
  Lines       20624    20624           
  Branches    10233    10233           
=======================================
  Hits        13100    13100           
  Misses       5395     5395           
  Partials     2129     2129           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevinbackhouse
Copy link
Collaborator Author

All the checks passed, so I'm fairly confident now that this will fix the build failures that all of our PRs are currently getting.

@kmilos
Copy link
Collaborator

kmilos commented Sep 19, 2022

Not all, I do have a real problem w/ overloading a new method w/ 3 arguments...

@kevinbackhouse kevinbackhouse merged commit 250586e into Exiv2:main Sep 19, 2022
@kevinbackhouse kevinbackhouse deleted the conan-1.52.0 branch September 19, 2022 12:33
postscript-dev added a commit that referenced this pull request Oct 18, 2022
- This is a partial backport of #2364. The new exceptions in `::setExifData()`/`::setIptcData()`/`::setXmpData()` are not included as they could change the control flow of the maintenance branch for the user.
- Conan change is a backport of #2361
- Closes #2350
antermin pushed a commit to antermin/exiv2 that referenced this pull request Mar 16, 2023
- This is a partial backport of Exiv2#2364. The new exceptions in `::setExifData()`/`::setIptcData()`/`::setXmpData()` are not included as they could change the control flow of the maintenance branch for the user.
- Conan change is a backport of Exiv2#2361
- Closes Exiv2#2350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Issues related with CI jobs Conan Handle external dependencies via Conan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants