Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

[FRONTEND-99] [Web] fix IE issue in v3.3.1 via hack to include Object.entries pollyfill from core-js #9

Merged
merged 2 commits into from
Feb 7, 2020
Merged

[FRONTEND-99] [Web] fix IE issue in v3.3.1 via hack to include Object.entries pollyfill from core-js #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a25a08e
Adds hack to include Object.entries pollyfill for all builds
theinterned Feb 7, 2020
8d3eb4c
update pkg.version to 3.3.1-pr9 to match this PR number
theinterned Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ module.exports = function(webpackEnv) {
// These are the "entry points" to our application.
// This means they will be the "root" imports that are included in JS bundle.
entry: [
// START: EVERLONG CHANGES - FRONTEND-99
// this is hopefully a temporary fix for
// https://github.com/facebook/create-react-app/issues/8405
// from this comment:https://github.com/facebook/create-react-app/issues/8405#issuecomment-582388530
'./node_modules/core-js/es/object/entries.js',
// END: EVERLONG CHANGES - FRONTEND-99

// Include an alternative client for WebpackDevServer. A client's job is to
// connect to WebpackDevServer by a socket and get notified about changes.
// When you save a file, the client will either apply hot updates (in case
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@everlong/league-react-scripts",
"version": "3.3.1",
"version": "3.3.1-pr9",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this pr number to the version string so that we can publish our patched version separately from the version numbers used by the upstream CRA project.

"description": "Everlong configuration and scripts for Create React App.",
"repository": {
"type": "git",
Expand Down