This repository has been archived by the owner on May 13, 2022. It is now read-only.
[FRONTEND-99] [Web] fix IE issue in v3.3.1 via hack to include Object.entries pollyfill from core-js
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11 was failing in dev mode due to missing Object.entries polyfill in `react-erro-overlay` :( facebook#8405 (comment)
theinterned
changed the base branch from
master
to
FRONTEND-84-Upgrade-Everlong-s-CRA-to-v3-3-x
theinterned
changed the base branch from
FRONTEND-84-Upgrade-Everlong-s-CRA-to-v3-3-x
to
master
theinterned
commented
Feb 7, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@everlong/league-react-scripts", | |||
| "version": "3.3.1", | |||
| "version": "3.3.1-pr9", | |||
There was a problem hiding this comment.
I added this pr number to the version string so that we can publish our patched version separately from the version numbers used by the upstream CRA project.
martakule
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do a temporary hack to the CRA Webpack config to fix a babel issue in react-error-overlay
facebook#8405 (comment)
I am following this issue and will update our fork to revert the hack when the issue is properly resolved.
I’ve created a separate issue to track that: https://everlong.atlassian.net/browse/FRONTEND-100
Note
This hack bring the Object.entries pollyfill in for all environments / browsers. I don't think that's a huge problem but something to monitor and roll back from asap.