Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): fix calcite-switch semantics #269

Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix(a11y): fix calcite-switch semantics #269

merged 1 commit into from
Dec 19, 2019

Conversation

jcfranco
Copy link
Member

This fixes a regression caused by #259.

@jcfranco jcfranco added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 19, 2019
@jcfranco jcfranco added this to the 🔨 v1-beta.17 milestone Dec 19, 2019
@jcfranco jcfranco requested review from paulcpederson, macandcheese and a team December 19, 2019 20:08
@jcfranco jcfranco self-assigned this Dec 19, 2019
macandcheese
macandcheese approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

driskull
driskull approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 0e5af5e into master Dec 19, 2019
@jcfranco jcfranco deleted the jcfranco/fix-switch-semantics branch December 19, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@macandcheese macandcheese macandcheese approved these changes

@paulcpederson paulcpederson Awaiting requested review from paulcpederson

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
v1.0.0-beta.17
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @driskull @macandcheese