Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use text values for boolean ARIA attributes. #259

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Use text values for boolean ARIA attributes. #259

merged 1 commit into from
Dec 7, 2019

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 6, 2019

This fixes some issues caught by axe where it would complain about aria-some-boolean-attribute="" being invalid.

@jcfranco jcfranco added this to the 🔨 v1-beta.16 milestone Dec 6, 2019
@jcfranco jcfranco self-assigned this Dec 6, 2019
@jcfranco jcfranco mentioned this pull request Dec 6, 2019
Merged
@paulcpederson
Copy link
Member

Beautiful 💯

@jcfranco jcfranco merged commit bdab7a9 into master Dec 7, 2019
@jcfranco jcfranco deleted the jcfranco/use-text-value-for-text-attrs branch December 7, 2019 00:59
@jcfranco jcfranco mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcpederson paulcpederson paulcpederson approved these changes

@patrickarlt patrickarlt Awaiting requested review from patrickarlt

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@jcfranco jcfranco

Labels
None yet
Projects
None yet
Milestone
v1.0.0-beta.16
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @paulcpederson