Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-picker): ensure shorthand hex is expanded regardless of alpha channel presence #11188

Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 2, 2025

Related Issue: #11187

Summary

Fixes a regression from #9701, where only RGBA shorthand hex values would be accepted by calcite-color-picker-hex-input.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 2, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 2, 2025
@jcfranco jcfranco requested a review from aPreciado88 January 8, 2025 08:42
@jcfranco jcfranco marked this pull request as ready for review January 8, 2025 08:42
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcfranco jcfranco merged commit dc7a0ef into dev Jan 8, 2025
10 of 11 checks passed
@jcfranco jcfranco deleted the jcfranco/11187-ensure-shorthand-hex-is-expanded-on-blur branch January 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants