Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[color-picker] shorthand RGB hex should be accepted with alpha-channel #11187

Closed
2 of 6 tasks
jcfranco opened this issue Jan 2, 2025 · 2 comments
Closed
2 of 6 tasks

[color-picker] shorthand RGB hex should be accepted with alpha-channel #11187

jcfranco opened this issue Jan 2, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2025-01-30 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented Jan 2, 2025

Check existing issues

Actual Behavior

Shorthand RGB hex is no longer expanded when the input is blurred.

Expected Behavior

Shorthand hex should be accepted regardless of alpha channel being present or not.

Reproduction Sample

https://codepen.io/jcfranco/pen/pvzWmaq?editors=100

Reproduction Steps

  1. click on hex input
  2. select all text
  3. type any shorthand rgb hex (e.g., abc)
  4. blur input
  5. notice original value is restored

Reproduction Version

2.13.2

Relevant Info

Looks like this was introduced in #9701.

Regression?

2.10.1

Priority impact

impact - p3 - not time sensitive

Impact

This might affect users that assume blurring inputs will expand shorthand hex values.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 2, 2025
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 2, 2025
@jcfranco jcfranco mentioned this issue Jan 2, 2025
Merged
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 6, 2025
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jan 6, 2025
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 7, 2025
jcfranco added a commit that referenced this issue Jan 8, 2025
@jcfranco
fix(color-picker): ensure shorthand hex is expanded regardless of alp…
dc7a0ef 
…ha channel presence (#11188)

**Related Issue:** #11187 

## Summary

Fixes a regression from
#9701, where only RGBA
shorthand hex values would be accepted by
`calcite-color-picker-hex-input`.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jan 8, 2025
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 9, 2025
@geospatialem
Copy link
Member

Verified on the dev branch via keyboard and mouse

verify-hex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP