Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.4.0 #177

Merged
merged 71 commits into from
Mar 5, 2021
Merged

Release/0.4.0 #177

merged 71 commits into from
Mar 5, 2021

Conversation

brianespinosa
Copy link
Contributor

@brianespinosa brianespinosa commented Mar 5, 2021

Dependencies

We updated a number of dependencies in this release with no breaking changes

Manu Ramirez and others added 24 commits March 3, 2021 12:01
feat(Table): Conditional actions
chore(fix eslint): Resolve all `import` plugin eslint rules
… name, func comp, jsx bool)

Resolves FDS-151

## Fixes rules

```
'react/button-has-type': 0,
'react/display-name': 0,
'react/function-component-definition': 0,
'react/jsx-boolean-value': 0,
```
chore(FDS-146): Resolve eslint `prefer-` prefixed errors
…FDS-151-eslint-some-react

# Conflicts:
#	.eslintrc.js
…eact

chore(FDS-151): Resolve some eslint react rules (button type, display name, func comp, jsx bool)
Resolves FDS-152

This should make our PRs automatically squash against develop when other PRs get merged.
…omment-style` (#170)

Fixes eslint rules:

'multiline-comment-style': 0,
'no-alert': 0,
'no-extra-boolean-cast': 0,
'no-prototype-builtins': 0,
'no-useless-return': 0,

Co-authored-by: Manuel Ramirez <lordpixel@users.noreply.github.com>
…-types' (#174)

* chore(FDS-147) - fix eslint errors for 'react/prop-types' and react/forbid-prop-types'

* chore(FDS-147) - remove silly invocation from 'element' prop type

* chore(FDS-147) - address PR review comments

* Update app-tests/_templates/next-template/src/pages/index.js

Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>

* Update app-tests/_templates/next-template/src/pages/_document.js

Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>

* chore(FDS-147) - address PR review comments

Co-authored-by: Manu Ramirez <manu.ramirez@espressive.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>
Resolves FDS-155

This fixture should show what happens when we have a handler function that is not wrapped with `useCallback` and how that impacts the use of `React.memo`.

We might actually want to create a collection of fixtures like this to share with the FE team. Hmm…
* chore(FDS-147) - fix eslint errors for 'react/prop-types' and react/forbid-prop-types'

* chore(FDS-153) - fix remaining eslint errors

consistent-return
eslint-comments/disable-enable-pair
eslint-comments/no-unused-disable
eslint-comments/require-description
jest/no-done-callback
react/jsx-key
react/jsx-no-bind
react/no-unknown-property
sort-imports
sort-keys

* chore(FDS-153) - address PR comments

* chore(FDS-153) - address PR comments (2)

* chore(FDS-153) - fix eslint for new fixture

Co-authored-by: Manu Ramirez <manu.ramirez@espressive.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 - docs@0.4.0
 - @espressive/cascara@0.4.0
 - @espressive/babel-preset-espressive@0.2.5
 - @espressive/eslint-config@1.0.1
 - @espressive/legacy-css@2.0.4
@ghost
Copy link

ghost commented Mar 5, 2021

Warnings
⚠️ Please assign someone to merge this PR, and optionally include people who should review.
Messages
📖

packages/cascara/src/modules/AllModules.fixture.js: This fixture has been changed.

📖

packages/cascara/src/modules/poc/ContextComposability.fixture.js: This fixture has been changed.

📖

packages/cascara/src/modules/poc/ContextComposableActions.fixture.js: This fixture has been changed.

📖

packages/cascara/src/placeholders/AreaPlaceholder/AreaPlaceholder.fixture.js: This fixture has been changed.

📖

packages/cascara/src/placeholders/JsonPlaceholder/JsonPlaceholder.fixture.js: This fixture has been changed.

📖

packages/cascara/src/structures/Admin/Admin.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Button/Button.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Chat/fixtures/ChatPublicAPI.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Dashboard/poc/DashboardPAC.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Form/poc/FormPublicAPI.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Popover/Popover.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Section/Section.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Table/fixtures/ActionStack.Table.fixture.js: This fixture has been changed.

📖

packages/cascara/src/ui/Table/fixtures/EdiTable.fixture.js: This fixture has been changed.

Generated by 🚫 dangerJS against 53a446a

@brianespinosa brianespinosa enabled auto-merge (squash) March 5, 2021 18:00
@brianespinosa brianespinosa merged commit 21f9dad into main Mar 5, 2021
@brianespinosa brianespinosa deleted the release/0.4.0 branch March 5, 2021 18:11
@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/espressive/cascara/GzdsgEjeV1xnnXPbG7bgM8uxobNn
✅ Preview: https://cascara-git-release-040-espressive1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants