Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FDS-151): Resolve some eslint react rules (button type, display name, func comp, jsx bool) #171

Merged
merged 2 commits into from
Mar 3, 2021
Merged

chore(FDS-151): Resolve some eslint react rules (button type, display name, func comp, jsx bool) #171

merged 2 commits into from
Mar 3, 2021

Conversation

brianespinosa
Copy link
Contributor

Resolves FDS-151

Fixes rules

'react/button-has-type': 0,
'react/display-name': 0,
'react/function-component-definition': 0,
'react/jsx-boolean-value': 0,

@brianespinosa
chore(FDS-151): Resolve some eslint react rules (button type, display…
bbe31e7 
… name, func comp, jsx bool)

Resolves FDS-151

## Fixes rules

```
'react/button-has-type': 0,
'react/display-name': 0,
'react/function-component-definition': 0,
'react/jsx-boolean-value': 0,
```
@vercel
Copy link

vercel bot commented Mar 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/espressive/cascara/BHFJYRGqoreVSnjzN85HNMN2LyrX
✅ Preview: https://cascara-git-feature-fds-151-eslint-some-react-espressive1.vercel.app

@brianespinosa brianespinosa self-assigned this Mar 3, 2021
@brianespinosa brianespinosa requested a review from lordpixel March 3, 2021 21:42
@brianespinosa brianespinosa enabled auto-merge March 3, 2021 21:42
@ghost
Copy link

ghost commented Mar 3, 2021 •
edited by ghost
Loading

Messages
📖

packages/cascara/src/modules/AllModules.fixture.js: This fixture has been changed.
📖

packages/cascara/src/ui/Button/Button.fixture.js: This fixture has been changed.
📖

packages/cascara/src/ui/Form/poc/FormPublicAPI.fixture.js: This fixture has been changed.
📖

packages/cascara/src/ui/Section/Section.fixture.js: This fixture has been changed.

Generated by 🚫 dangerJS against f7a62a1

lordpixel
lordpixel previously approved these changes Mar 3, 2021
View reviewed changes
@brianespinosa
Merge branch 'develop' of github.com:Espressive/cascara into feature/…
f7a62a1 
…FDS-151-eslint-some-react

# Conflicts:
#	.eslintrc.js
@brianespinosa brianespinosa merged commit 60f7650 into develop Mar 3, 2021
@brianespinosa brianespinosa deleted the feature/FDS-151-eslint-some-react branch March 3, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordpixel lordpixel lordpixel approved these changes

Assignees

@brianespinosa brianespinosa

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianespinosa @lordpixel