Develop to Master for next release #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And into the end of the setup of all examples The system was going to sleep before setting up the test button.
Totally untested
Needed for the calculated variables in arrays
This will always be dependent on the user implementing the -9999 return in their calculation function.
Not sure why I thought this could not be done.
based on results from bme280timeTest.ino. See https://docs.google.com/spreadsheets/d/1nh95sV7RreeaHTInxipFUqsnYnVjkwiUVIucD7rIk4E/edit#gid=1494267475
but instead contains a variable array object as an internal member Also made the former init function into a constructor
Also, 0 is a valid pin number
I like the logger info better at the top, even if we create the logger at the bottom.
Kill init
Pointer ref
Except for XBee's, which do not return a signal strength until after a full TCP connection is made. Other modems can ask for CSQ even without being registered to the network. Need to verify this for ESP8266's.
Implemented real calculated variables. Also fix to Sonar results instability due to buffer not being cleared.
SRGDamia1
reviewed
Sep 7, 2018
|
@SRGDamia1, I just issued release 0.12.2. https://github.com/EnviroDIY/ModularSensors/releases Also, How do we register this new release with PlatformIO? Can you do that and/or explain how? Thanks. |
|
As long as the version number in library.json and the release name are the same, platformio should detect and pull in the release version automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been 56 commits since
Developwas pulled intoMasteras version 0.11.7 with PR #152 on May 18. Most notably, PR#153 merged thecalVarbranch intoDevelopafter 49 commits and relatively extensive testing and dialog.The last official release was for version 0.11.6 on May 11, after PR #146.
I think we are ready to merge and issue a new release.
Presently, this version is tagged as
0.12.2. Do we need the version to be updated?