Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly send reestablish on close channels, do it simpler. #7353

Merged
merged 2 commits into from
May 29, 2024
Merged

Properly send reestablish on close channels, do it simpler. #7353

merged 2 commits into from
May 29, 2024

Commits on May 29, 2024

  1. pytest: test that we get REESTABLISH msg reply on closed channels. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7c05216 View commit details
    Browse the repository at this point in the history

  2. lightningd: send CHANNEL_REESTABLISH ourselves on closed channels. 

    We used to fire up channeld to send this, but:
1. That's silly, we have all the information to make it ourselves.
2. We didn't do it if there was an error on the channel, which as of 24.02
   there always is!
3. When it did work, running channeld *stops* onchaind, indefinitely slowing recovery.

Fixes: Blockstream/greenlight#433
Changelog-Fixed: Protocol: we once again send CHANNEL_REESTABLISH responses on closing channels.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e615daf View commit details
    Browse the repository at this point in the history