Properly send reestablish on close channels, do it simpler. #7353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We used to fire up channeld to send this, but: 1. That's silly, we have all the information to make it ourselves. 2. We didn't do it if there was an error on the channel, which as of 24.02 there always is! 3. When it did work, running channeld *stops* onchaind, indefinitely slowing recovery. Fixes: Blockstream/greenlight#433 Changelog-Fixed: Protocol: we once again send CHANNEL_REESTABLISH responses on closing channels. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/onchaind-restart-htlc-track
branch
from
5d43030
to
e615daf
Compare
vincenzopalazzo
approved these changes
May 29, 2024
|
ACK e615daf |
endothermicdev
merged commit 1d4783a
into
ElementsProject:master
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to fire up channeld to send this, but:
there always is!
Fixes: Blockstream/greenlight#433