Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin weaning code off assumption that unannounced channels are in gossip store #6697

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Begin weaning code off assumption that unannounced channels are in gossip store #6697

merged 6 commits into from
Oct 3, 2023

Commits on Oct 2, 2023

  1. plugins/topology: remove unused fuzz factor. 

    This breaks Dijkstra, which is presumably why it was actually
disabled.  Remove the code altoghether, instead.

Changelog-Fixed: JSON-RPC: `getroute` now documents that it ignores `fuzzpercent`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    3f22fc9 View commit details
    Browse the repository at this point in the history

  2. plugins/topology: split getroute logic. 

    Mechanical change to bundle into struct getroute_info for next
patch which uses callback.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    77c9767 View commit details
    Browse the repository at this point in the history

  3. plugins/topology: convert listpeerchannels into local overlay. 

    This prepares us for when the gossmap doesn't contain private channel info.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    77821a0 View commit details
    Browse the repository at this point in the history

  4. renepay: work around change in fundchannel in tests. 

    The tests will wait until it's locally enabled, but it might not have
the update in the gossip store.  So have renepay enhance its local
view even if it already knows about the channel (this is correct
anyway, it just isn't very important usually).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    782f2c6 View commit details
    Browse the repository at this point in the history

  5. pytest: remove old test_tlv_or_legacy 

    We no longer support legacy at all, so this test doesn't really
test anything.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a471672 View commit details
    Browse the repository at this point in the history

  6. pytest: wean many tests off the assumption that listchannels shows pr… 

    …ivate channels.

We will be changing this, or at least deprecating it, so get our
tests ready.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    384106e View commit details
    Browse the repository at this point in the history