Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin weaning code off assumption that unannounced channels are in gossip store #6697

Conversation

rustyrussell
Copy link
Contributor

This is incomplete, but should make changing this easier. We will probably have to change listchannels (at least in deprecated mode!) to add local channels, but we can do that at the end.

This series is really a precursor for @endothermicdev to rebase onto.

@rustyrussell rustyrussell added this to the v23.11 milestone Sep 21, 2023
@rustyrussell rustyrussell changed the title Begin process of weaning code off assumption that unannounced channels are in gossip store Begin weaning code off assumption that unannounced channels are in gossip store Sep 21, 2023
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like that this is vreaking some C test?

643.3 ld connectd/test/run-netaddress
643.4 ld connectd/test/run-responder-success
643.4 ld connectd/test/run-websocket
643.4 ld wallet/test/run-db
643.4 ld wallet/test/run-psbt_fixup
wallet/test/run-wallet.o: in function `wallet_rune_update_last_used':
643.7 /repo/./wallet/wallet.c:5765: undefined reference to `rune_unique_id'
643.7 collect2: error: ld returned 1 exit status
643.7 make: *** [Makefile:664: wallet/test/run-wallet] Error 1
643.7 rm external/build-x86_64-alpine-linux-musl/libwally-core-build/src/secp256k1/libsecp256k1.la

This breaks Dijkstra, which is presumably why it was actually
disabled.  Remove the code altoghether, instead.

Changelog-Fixed: JSON-RPC: `getroute` now documents that it ignores `fuzzpercent`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Mechanical change to bundle into struct getroute_info for next
patch which uses callback.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This prepares us for when the gossmap doesn't contain private channel info.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The tests will wait until it's locally enabled, but it might not have
the update in the gossip store.  So have renepay enhance its local
view even if it already knows about the channel (this is correct
anyway, it just isn't very important usually).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We no longer support legacy at all, so this test doesn't really
test anything.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ivate channels.

We will be changing this, or at least deprecating it, so get our
tests ready.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell merged commit 176a58f into ElementsProject:master Oct 3, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants