-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to match BOLT master #6668
Update to match BOLT master #6668
Commits on Sep 11, 2023
-
wire: fix up messy patches (make extract-peer-csv)
They didn't actually apply properly! I regenerated the dual-funding CSV from the latest commit (091397fc0798c4b2bdb36dbaa9f5b4b1d4a463e1) and made it a single patch. I tried doing the same for splicing, but the implementation has drifted far from the spec, so I simply opted for a patch which didn't change anything. You can see the resulting "wire/peer_wire.csv" is the same, except fields are now in a less-random order! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for d2375b6 - Browse repository at this point
Copy the full SHA d2375b6View commit details -
wire: fix up messy patches (make extract-onion-csv)
These patches are no longer necessary now blinded payments were merged into the spec. However, the spec did rename "blinding_point" inside `payload` to "current_blinding_point" so we temporarily add a patch to change it back. You can see wire/onion_wire.csv is reordered, but unchanged. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for d54b34f - Browse repository at this point
Copy the full SHA d54b34fView commit details -
common: rename tlv_payload's "blinding_point" to "current_blinding_po…
…int" as per spec. Simple rename in a few internal places. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for e10b5f5 - Browse repository at this point
Copy the full SHA e10b5f5View commit details
Commits on Sep 12, 2023
-
doc: update to BOLT 29c14c6e12cbdf33f6b724094c81658a614d2e02 "fix typos"
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 7fe728b - Browse repository at this point
Copy the full SHA 7fe728bView commit details -
doc: update to BOLT 50b2df24a27879e8329712c275db78876fd022fe "Update …
…onion errors since we allow overpaying or under-CLTVing" We already do this behaviour, we just didn't adjust comments. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for ab646fc - Browse repository at this point
Copy the full SHA ab646fcView commit details -
common: remove channel_id check.
connectd demuxes for us, so this can never trigger. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 7ddda9b - Browse repository at this point
Copy the full SHA 7ddda9bView commit details -
common: don't send channel_id on peer error.
It's unused: they know what channel it is. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for ec42122 - Browse repository at this point
Copy the full SHA ec42122View commit details -
common: don't hang up when we receive a warning.
We were allowed to, but the spec removed that. So we handle warnings differently from errors now. This also means the LND "internal error" workaround is done in lightningd (we still disconnect, but we don't want to close channel). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: Protocol: we no longer disconnect every time we receive a warning message.
Configuration menu - View commit details
-
Copy full SHA for 2b14d92 - Browse repository at this point
Copy the full SHA 2b14d92View commit details -
connectd: also don't disconnect on "all-channel" warnings.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 5c4188b - Browse repository at this point
Copy the full SHA 5c4188bView commit details -
doc: update to BOLT 3747ba83022cd385093df2696ed342f1e41e31b3 "Remove …
…requirements to disconnect on warnings" Now we don't do that anymore (at least, for sending) we can update bolt quotes to match. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 1e90cb0 - Browse repository at this point
Copy the full SHA 1e90cb0View commit details -
wire: update to BOLT aad959a297ff66946effb165518143be15777dd6 "tools:…
… remove option handling now last optional field was removed." No effect on us, we didn't use this field anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 35f83ba - Browse repository at this point
Copy the full SHA 35f83baView commit details -
doc: update to BOLT 7f53a3e46ed59f19463447d5fa63b3e484c708a5 "BOLT 8:…
… make it clear that there are *two* chaining keys." Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for d78c9c2 - Browse repository at this point
Copy the full SHA d78c9c2View commit details -
lightningd: update to BOLT 7d3ef5a6b20eb84982ea2bfc029497082adf20d8 "…
…Allow unset `onion_hash` in `invalid_onion_blinding` (ElementsProject#1093)" Explicitly allow all-zero in the onion_hash: we didn't do anything except log if it was unexpected anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for c49dc6c - Browse repository at this point
Copy the full SHA c49dc6cView commit details -
doc: update to BOLT cded2df1fd0095c947af02a52e28b16c66bdfc5c "Fix und…
…eclared reference in onion-routing" Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for 0166dd5 - Browse repository at this point
Copy the full SHA 0166dd5View commit details -
wire: update to BOLT 17ceba42dc6607b637a713a9bc051f63c1357edd "BOLT 4…
…: onion message support." We don't need to patch it in anymore, now it's merged. However, we do move the message itself from onion_wire.csv to peer_wire.csv (we should get more sophisticated with our parsing, but this works for now!). The resulting peer_wire.csv is identical, the onion_wire.csv file is slightly reordered. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for af5bb32 - Browse repository at this point
Copy the full SHA af5bb32View commit details -
bolt11: update to BOLT 7dda8f84edb8655766d83619cb41110c1bf43f85 "Bolt…
…11: min_final_cltv_expiry_delta is optional, not required (ElementsProject#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for f910b20 - Browse repository at this point
Copy the full SHA f910b20View commit details -
doc: update to BOLT 6e85df448bfee7d10f26aabb06b8eba3d7505888 "BOLT2: …
…change "reject" to "fail" in channel opening requirements (ElementsProject#1104)" Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Configuration menu - View commit details
-
Copy full SHA for e938b2e - Browse repository at this point
Copy the full SHA e938b2eView commit details