Update to match BOLT master #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They didn't actually apply properly! I regenerated the dual-funding CSV from the latest commit (091397fc0798c4b2bdb36dbaa9f5b4b1d4a463e1) and made it a single patch. I tried doing the same for splicing, but the implementation has drifted far from the spec, so I simply opted for a patch which didn't change anything. You can see the resulting "wire/peer_wire.csv" is the same, except fields are now in a less-random order! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
These patches are no longer necessary now blinded payments were merged into the spec. However, the spec did rename "blinding_point" inside `payload` to "current_blinding_point" so we temporarily add a patch to change it back. You can see wire/onion_wire.csv is reordered, but unchanged. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…int" as per spec. Simple rename in a few internal places. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…onion errors since we allow overpaying or under-CLTVing" We already do this behaviour, we just didn't adjust comments. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
connectd demuxes for us, so this can never trigger. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's unused: they know what channel it is. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
the
protocol
We were allowed to, but the spec removed that. So we handle warnings differently from errors now. This also means the LND "internal error" workaround is done in lightningd (we still disconnect, but we don't want to close channel). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: Protocol: we no longer disconnect every time we receive a warning message.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…requirements to disconnect on warnings" Now we don't do that anymore (at least, for sending) we can update bolt quotes to match. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… remove option handling now last optional field was removed." No effect on us, we didn't use this field anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… make it clear that there are *two* chaining keys." Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…Allow unset `onion_hash` in `invalid_onion_blinding` (ElementsProject#1093)" Explicitly allow all-zero in the onion_hash: we didn't do anything except log if it was unexpected anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…eclared reference in onion-routing" Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…: onion message support." We don't need to patch it in anymore, now it's merged. However, we do move the message itself from onion_wire.csv to peer_wire.csv (we should get more sophisticated with our parsing, but this works for now!). The resulting peer_wire.csv is identical, the onion_wire.csv file is slightly reordered. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…11: min_final_cltv_expiry_delta is optional, not required (ElementsProject#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…change "reject" to "fail" in channel opening requirements (ElementsProject#1104)" Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/spec-update
branch
from
8d68634
to
e938b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.