Commits on Jul 19, 2023

1. pytest: Remove tests that rely on presplit behavior …

   These tests make assumptions about the presplitter behavior which
   we'll remove in the next commit. We remove them here so we don't cause
   temporary breaks in the git history.

   

   cdecker committed Jul 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 67e13f3
   • Browse repository at this point

   Copy the full SHA

   67e13f3 View commit details

   Browse the repository at this point in the history

2. pay: Remove the presplitter modifier …

   The presplitter modifier would split a payment before trying the first
   attempt based on some common sizes. Its goal was to have smaller parts
   in flight over different paths, in order to make it more difficult for
   a forwarding node to learn payment amount. However it was causing some
   issues for direct payments, and estimates on spendable amounts which
   considers only the first HTLC being added, but presplitter would
   always cause multiple HTLCs to be kicked off, causing the estimate to
   be off.
   
   Removing the presplitter fixes this, making draining channels easier,
   and worse success rates, due to more HTLCs in flight directly
   impacting the changes of getting stuck.
   
   Changelog-Removed: pay: `pay` no longer splits based on common size, as it was causing issues in various scenarios.

   

   cdecker committed Jul 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e7ae2d9
   • Browse repository at this point

   Copy the full SHA

   e7ae2d9 View commit details

   Browse the repository at this point in the history

3. libplugin: Remove presplitter from the API

   

   cdecker committed Jul 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 312d57c
   • Browse repository at this point

   Copy the full SHA

   312d57c View commit details

   Browse the repository at this point in the history