pay: Remove presplitter #6400
Merged
pay: Remove presplitter #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hit a known flake which I've got a fix for in another PR. Could use a Changelog-Changed: line though? Ack 05060fa |
rustyrussell
approved these changes
Jul 15, 2023
|
There is a |
These tests make assumptions about the presplitter behavior which we'll remove in the next commit. We remove them here so we don't cause temporary breaks in the git history.
The presplitter modifier would split a payment before trying the first attempt based on some common sizes. Its goal was to have smaller parts in flight over different paths, in order to make it more difficult for a forwarding node to learn payment amount. However it was causing some issues for direct payments, and estimates on spendable amounts which considers only the first HTLC being added, but presplitter would always cause multiple HTLCs to be kicked off, causing the estimate to be off. Removing the presplitter fixes this, making draining channels easier, and worse success rates, due to more HTLCs in flight directly impacting the changes of getting stuck. Changelog-Removed: pay: `pay` no longer splits based on common size, as it was causing issues in various scenarios.
cdecker
force-pushed
the
20230713-no-presplit
branch
from
05060fa
to
312d57c
Compare
|
Rebased on top of |
vincenzopalazzo
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
ACK 312d57c
I like this simplification. It was the root cause of some problems, when this is merged, I will walk through the issues and see if we solve them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presplitter modifier would split a payment before trying the first
attempt based on some common sizes. Its goal was to have smaller parts
in flight over different paths, in order to make it more difficult for
a forwarding node to learn payment amount. However it was causing some
issues for direct payments, and estimates on spendable amounts which
considers only the first HTLC being added, but presplitter would
always cause multiple HTLCs to be kicked off, causing the estimate to
be off.
Removing the presplitter fixes this, making draining channels easier,
and worse success rates, due to more HTLCs in flight directly
impacting the changes of getting stuck.