lnprototest build fix #5583
Merged
lnprototest build fix #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires us to update to latest lnproto which is now using the most up to date python-bitcoinlib, as well as updating our python lock files (which pin the grpcio deps, because of locking problems h/t @cdecker)
Few extremely minor updates to the ubuntu dockerfile and ci builds
|
@chrisguida this might be of interest to you |
|
Lnprototest is merged but now include a not merged version of the pyln bolts #5562 for this reason I did not finish the bolts refactoring in my original pr in lnprototest :) Maybe we can merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we can update to ubuntu 22.04 LTS and that fixes all the
makoproblems (for now, should def be addressed more widely for everyone that can't update). This required a bit of a detour intohashlib(but thankfully python-bitcoinlib had already taken care of an update for this, so we just re-use their implementation)Also fixes up a few tiny things I found.
Points at my
lnprototestbranch, which has updates needed to make the move to 22.04 LTS work; we can update it back once that's merged (or gate this PR on that one being merged to mainline).