Pyln bolt update #5562
Closed
Pyln bolt update #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Aug 31, 2022
Merged
cdecker
force-pushed
the
pyln-bolt-update
branch
from
ef6bb85
to
f329425
Compare
Suggested-by: Vincenzo Palazzo <@vincenzopalazzo>
We want the tests to run against the source that is currently checked out not an installed version, and we want to isolate things with poetry. Changelog-None
They were missing mypy and pytest to be tested in isolation
cdecker
force-pushed
the
pyln-bolt-update
branch
from
f329425
to
1adff56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite automated just yet, need to figure out how to get the
Makefileto callpoetry version __base_version__.__post_version__wheneverpyln/spec/bolt?/gen_version.pychanges, but good enough to get things tested and published manually for now.