Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups #4803

Merged
merged 6 commits into from
Sep 21, 2021
Merged

Minor cleanups #4803

merged 6 commits into from
Sep 21, 2021

Commits on Sep 20, 2021

  1. Configuration menu
    Copy the full SHA
    3b69e2c View commit details
    Browse the repository at this point in the history
  2. pay: Fix wrong result being returned by pay

    We were checking against the wrong enum value, resulting in an
    erroneous `pending` state as a final result.
    
    Changelog-Fixed: pay: `pay` would sometimes misreport a final state of `pending` instead of `failed`
    cdecker committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    db5a8e9 View commit details
    Browse the repository at this point in the history
  3. jsonrpc: Simplify the state decision of listpays

    It was really different from the way we decide the overall state of a
    `pay` command's output. Now we use a more similar state decision,
    based on collecting all states and checking them at the end to
    determine the outcome.
    cdecker committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ac1b6ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1ff08a0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4c7a5d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dd63899 View commit details
    Browse the repository at this point in the history