Minor cleanups #4803
Merged
Minor cleanups #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking against the wrong enum value, resulting in an erroneous `pending` state as a final result. Changelog-Fixed: pay: `pay` would sometimes misreport a final state of `pending` instead of `failed`
It was really different from the way we decide the overall state of a `pay` command's output. Now we use a more similar state decision, based on collecting all states and checking them at the end to determine the outcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had these laying around for some time, and finally bundled them up.
bcliEspecially the silencing of -27 should finally stabilize the lnprototests, but I'd like to have either @niftynei or @Rusty check that it's actually ok to do.