Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make onion messages and offers runtime-experimental #4328

Merged
merged 10 commits into from
Jan 13, 2021
Merged

Make onion messages and offers runtime-experimental #4328

merged 10 commits into from
Jan 13, 2021

Commits on Jan 13, 2021

  1. wire/Makefile: refactor to allow non-experimental spec patches. 

    And rename the current patches to all be _exp_*.patch.  These
are applied after the basic patches.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


Header from folded patch 'fix.patch':
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6f0ef14 View commit details
    Browse the repository at this point in the history

  2. wire: add bolt12_wire.csv 

    For some reason, an old version was checked in.  We don't currently
use it (since bolt12 support depends on EXPERIMENTAL_FEATURES, which
uses bolt12_exp_wire.csv, which is generated and not checked in).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c7cd592 View commit details
    Browse the repository at this point in the history

  3. wire: Apply onion mesages spec patch even when not experimental. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    79da4ed View commit details
    Browse the repository at this point in the history

  4. lightningd: control onion messages by experimental-onion-messages o… 

    …ption.

Note that this also changes so the feature is not represented in channels,
reflecting the recent drafts.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: `experimental-onion-messages` enables send, receive and relay of onion messages.
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    157560d View commit details
    Browse the repository at this point in the history

  5. plugins: allow plugins to disable themselves at startup. 

    By returning 'disable: <reason>' inside getmanifest or init result.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: plugins: plugins can now disable themselves by returning `disable`, even if marked important.
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    78d0f3f View commit details
    Browse the repository at this point in the history

  6. libplugin: make init return a string. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: libplugin: init can return a non-NULL string to disable the plugin.
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    b42a81c View commit details
    Browse the repository at this point in the history

  7. tools/generate-wire.py: include digits in #ifndef idempotent header. 

    Otherwise check complains that it's '#ifndef LIGHTNING_WIRE_BOLT_WIREGEN_H':

wire/bolt12_wiregen.h seems to be missing the expected include guard:
  #ifndef LIGHTNING_WIRE_BOLT12_WIREGEN_H
  #define LIGHTNING_WIRE_BOLT12_WIREGEN_H
  ...
  #endif /* LIGHTNING_WIRE_BOLT12_WIREGEN_H */

make: *** [Makefile:458: check-includes] Error 1

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    db099bd View commit details
    Browse the repository at this point in the history

  8. common/bolt12: include correct bolt12 wiregen header. 

    Don't include exp directly, use an ifdef in common/bolt12
(like we do for peer and onion wiregen files).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    104dc00 View commit details
    Browse the repository at this point in the history

  9. offers: make it a runtime option. 

    The fetchinvoice and offers plugins disable themselves if the option
isn't enabled (it's enabled by default on EXPERIMENTAL_FEATURES).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: `experimental-offers` enables fetch, payment and creation of (early draft) offers.
    @rustyrussell
    rustyrussell committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    989a205 View commit details
    Browse the repository at this point in the history

  10. travis: Bump number of valgrind configs to 12

    @cdecker
    cdecker committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    a85581f View commit details
    Browse the repository at this point in the history