Make onion messages and offers runtime-experimental #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good, but compiling on CI fails, could not reproduce that locally however. |
rustyrussell
force-pushed
the
guilt/runtime-experimental
branch
from
90f023b
to
99adb17
Compare
|
Yeah, I missed some exp hardwired into Makefile, and didn't check in the bolt12 generated files. Fixed, let's see what else.... |
rustyrussell
force-pushed
the
guilt/runtime-experimental
branch
from
99adb17
to
13bf943
Compare
And rename the current patches to all be _exp_*.patch. These are applied after the basic patches. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Header from folded patch 'fix.patch':
For some reason, an old version was checked in. We don't currently use it (since bolt12 support depends on EXPERIMENTAL_FEATURES, which uses bolt12_exp_wire.csv, which is generated and not checked in). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/runtime-experimental
branch
from
13bf943
to
7a69c2c
Compare
…ption. Note that this also changes so the feature is not represented in channels, reflecting the recent drafts. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: `experimental-onion-messages` enables send, receive and relay of onion messages.
By returning 'disable: <reason>' inside getmanifest or init result. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: plugins: plugins can now disable themselves by returning `disable`, even if marked important.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: libplugin: init can return a non-NULL string to disable the plugin.
Otherwise check complains that it's '#ifndef LIGHTNING_WIRE_BOLT_WIREGEN_H': wire/bolt12_wiregen.h seems to be missing the expected include guard: #ifndef LIGHTNING_WIRE_BOLT12_WIREGEN_H #define LIGHTNING_WIRE_BOLT12_WIREGEN_H ... #endif /* LIGHTNING_WIRE_BOLT12_WIREGEN_H */ make: *** [Makefile:458: check-includes] Error 1 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Don't include exp directly, use an ifdef in common/bolt12 (like we do for peer and onion wiregen files). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/runtime-experimental
branch
from
7a69c2c
to
97510d0
Compare
The fetchinvoice and offers plugins disable themselves if the option isn't enabled (it's enabled by default on EXPERIMENTAL_FEATURES). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: `experimental-offers` enables fetch, payment and creation of (early draft) offers.
rustyrussell
force-pushed
the
guilt/runtime-experimental
branch
from
97510d0
to
989a205
Compare
|
ACK a85581f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do some plugin API enhancements along the way to make this sane, though.