Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amount_sat/amount_msat audit results #3904

Merged
merged 4 commits into from
Aug 6, 2020
Merged

amount_sat/amount_msat audit results #3904

merged 4 commits into from
Aug 6, 2020

Commits on Aug 5, 2020

  1. amount: add helper to convert u64 sats to amount_sat type

    @niftynei @rustyrussell
    niftynei authored and rustyrussell committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    d80f652 View commit details
    Browse the repository at this point in the history

  2. amount: add amount_msat and amount_sat initializers. 

    Generally, importing amounts needn't be checked, and it cuts down on
the warnings we get.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a391c23 View commit details
    Browse the repository at this point in the history

  3. amount: use initializers everywhere. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    8d42bc7 View commit details
    Browse the repository at this point in the history

  4. amount: add amount_msat_scale, amount_msat_ratio, amount_{msat,sat}_div 

    It's not all that rare to do these operations, and requiring annotations
for it is a little painful.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    4c2dcc7 View commit details
    Browse the repository at this point in the history