amount_sat/amount_msat audit results #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally, importing amounts needn't be checked, and it cuts down on the warnings we get. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's not all that rare to do these operations, and requiring annotations for it is a little painful. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ZmnSCPxj
approved these changes
Aug 5, 2020
| @@ -401,22 +401,20 @@ bool amount_msat_to_u32(struct amount_msat msat, u32 *millisatoshis) | |||
| return true; | |||
| } | |||
|
|
|||
| void amount_msat_from_u64(struct amount_msat *msat, u64 millisatoshis) | |||
| struct amount_msat amount_msat(u64 millisatoshis) | |||
There was a problem hiding this comment.
I like this better than the void foo(out* out, int input) style. This is in fact what I thought AMOUNT_SAT/AMOUNT_MSAT did back when they were introduced, and was disappointed to learn they were just constexpr, boo.
The compiler might be able to optimize these better if we static inline these in the headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3902 @niftynei added a new helper: I took the opportunity to audit all our amount
/* Rawcomments and created a few new intuitive helpers. In particular, importing amounts isn't really an issue, though exporting them is still something I prefer people to look at carefully.Changelog-None