Update CI builder image to use bitcoind 0.16.0 and reduce number of required blocks #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
README file also mentions 432 blocks. |
|
Thanks, fixed up README.md and reduced from 121 to 101 (tested! 100 is not enough, 101 is). |
Now that 0.16.0 is stable we should make use of it Signed-off-by: Christian Decker <decker.christian@gmail.com>
0.16.0 is required since we rely on it for some tests and the block reduction allows us to waste less time during setup. 121 blocks were chosen so that we have at least one mature output to spend. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Since bitcoind 0.16 is already released it is safe to enable this test already.
FWIW, the tests without valgrind take 662 seconds before we reduced the number of blocks, and only 648 seconds now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
Ack 985362c |
|
Wondering what the timing implications are :-) |
|
@rustyrussell One more thing. README mentions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now seems to slightly overlap with #1127. Updates bitcoind to version 0.16.0 and reduces number of blocks pre-generated to 121, instead of 432. 121 are required at least so we have some mature funds.