Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_lightningd.py: Enable bech32 test for DEVELOPER #1127

Closed
wants to merge 3 commits into from
Closed

test_lightningd.py: Enable bech32 test for DEVELOPER #1127

wants to merge 3 commits into from

Conversation

jsarenik
Copy link
Collaborator

Since bitcoind 0.16 is already released it is safe to enable
this test already.

@jsarenik
Copy link
Collaborator Author

@cdecker could you please update docker image cdecker/lightning-ci to install bitcoind 0.16 in order for the bech32 test to pass? Thank you.

@jsarenik jsarenik mentioned this pull request Feb 27, 2018
Closed
@rustyrussell
Copy link
Contributor

Please also remove the 432-block check in test_lightning.py too: we now only need to generate 100 blocks (to get some funds to spend). Might speed up tests a little, too.

Jan Sarenik added 3 commits February 28, 2018 13:08
test_lightningd.py: Enable bech32 test for DEVELOPER
4665f3d 
Since bitcoind 0.16 is already released it is safe to enable
this test already.
test_lightningd.py: 100 blocks should be enough now
fcdf502 
Rusty wrote at #1127
On Tue, Feb 27, 2018 at 19:51:06 +0000 (UTC):
> Please also remove the 432-block check in test_lightning.py
> too: we now only need to generate 100 blocks (to get some funds
> to spend). Might speed up tests a little, too.
Dockerfile: Update bitcoin-core to 0.16.0
d8c80ca 
Uses BITCOIN_VERSION ENV variable in the beggining of Dockerfile.
@cdecker cdecker mentioned this pull request Feb 28, 2018
Merged
@cdecker
Copy link
Member

cdecker commented Feb 28, 2018

We have a bit of an overlap with #1134 now. 100 blocks isn't sufficient since we need at least one coinbase to be mature to be able to do anything. We also need to fix a few tests that rely on a specific blockchain height.

@cdecker
Copy link
Member

cdecker commented Feb 28, 2018

I cherry-picked your first commit onto #1134, so this now is completely superseded by it 😉
Cherry-picking will still give you credit for your commit though, which is important to me 😃

@jsarenik
Copy link
Collaborator Author

@cdecker Thanks! :)

@jsarenik
Copy link
Collaborator Author

@cdecker @rustyrussell Closing this pull request in favor of #1134 - though I would like to be included in further discussion regarding 100 blocks...

@jsarenik jsarenik closed this Feb 28, 2018
@jsarenik jsarenik deleted the jasan/bech32_test branch March 1, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsarenik @rustyrussell @cdecker