Fix 5.4 deprecs & types

.php-cs-fixer.php

@@ -24,20 +24,21 @@
     ->setFinder($finder)
     ->setRules([
         '@Symfony' => true,
+        'array_syntax' => ['syntax' => 'short'],
+        'concat_space' => ['spacing' => 'one'],
+        'header_comment' => ['header' => $header],
+        'native_function_invocation' => ['include' => ['@compiler_optimized']],
+        'no_unneeded_final_method' => false, // final private __construct is a valid use-case
+        'ordered_imports' => true,
         'php_unit_namespaced' => true,
         'php_unit_method_casing' => false,
-        'psr_autoloading' => true,
-        'concat_space' => ['spacing' => 'one'],
-        'phpdoc_summary' => false,
         'phpdoc_annotation_without_dot' => false,
+        'phpdoc_summary' => false,
         'phpdoc_order' => true,
-        'array_syntax' => ['syntax' => 'short'],
-        'ordered_imports' => true,
+        'phpdoc_trim_consecutive_blank_line_separation' => true,
+        'psr_autoloading' => true,
+        'single_line_throw' => false,
         'simplified_null_return' => false,
-        'header_comment' => ['header' => $header],
         'yoda_style' => [],
-        'no_unneeded_final_method' => false, // final private __construct is a valid use-case
-        'native_function_invocation' => ['include' => ['@compiler_optimized']],
-        'single_line_throw' => false,
     ])
 ;

Makefile

@@ -9,7 +9,6 @@ install: setup
 install:
 	rm -f composer.lock
 	composer config minimum-stability --unset
-	composer remove --no-interaction --dev "doctrine/mongodb-odm" "doctrine/mongodb-odm-bundle"
 	composer update --prefer-dist
 
 install-lowest: setup
@@ -24,10 +23,13 @@ install-highest:
 	composer config minimum-stability dev
 	composer update
 
-install-odm:
-	rm -f composer.lock
-	composer require --no-interaction --dev "doctrine/mongodb-odm:^2.2" "doctrine/mongodb-odm-bundle:^4.3"
-	composer update --prefer-dist
+add-odm:
+	composer require --no-update --no-interaction --dev "doctrine/mongodb-odm:^2.2" "doctrine/mongodb-odm-bundle:^4.3"
+	@echo "Run again appropriate install target to update dependencies"
+
+remove-odm:
+	composer remove --no-update --no-interaction --dev "doctrine/mongodb-odm" "doctrine/mongodb-odm-bundle"
+	@echo "Run again appropriate install target to update dependencies"
 
 ########
 # Test #

src/Bridge/Doctrine/DBAL/Types/AbstractCsvCollectionEnumType.php

@@ -16,6 +16,9 @@
 
 abstract class AbstractCsvCollectionEnumType extends SimpleArrayType
 {
+    /**
+     * @return mixed
+     */
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
     {
         if (\is_array($value)) {
@@ -27,6 +30,9 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform)
         return parent::convertToDatabaseValue($value, $platform);
     }
 
+    /**
+     * @return mixed
+     */
     public function convertToPHPValue($value, AbstractPlatform $platform)
     {
         if ($value === null) {

src/Bridge/Doctrine/DBAL/Types/AbstractEnumSQLDeclarationType.php

@@ -20,7 +20,7 @@ abstract class AbstractEnumSQLDeclarationType extends AbstractEnumType
     /**
      * {@inheritdoc}
      */
-    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
+    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
     {
         $values = implode(', ', array_map(static function (string $value): string {
             return "'$value'";

src/Bridge/Doctrine/DBAL/Types/AbstractEnumType.php

@@ -52,6 +52,8 @@ protected function onNullFromPhp()
      *
      * @param EnumInterface|null $value
      * @psalm-param T|null $value
+     *
+     * @return mixed
      */
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
     {
@@ -64,6 +66,8 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform)
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function convertToPHPValue($value, AbstractPlatform $platform)
     {
@@ -79,7 +83,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
     /**
      * {@inheritdoc}
      */
-    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
+    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
     {
         return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration);
     }
@@ -95,7 +99,7 @@ public function getDefaultLength(AbstractPlatform $platform)
     /**
      * {@inheritdoc}
      */
-    public function requiresSQLCommentHint(AbstractPlatform $platform)
+    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
     {
         return true;
     }

src/Bridge/Doctrine/DBAL/Types/AbstractIntegerEnumType.php

@@ -17,15 +17,15 @@ abstract class AbstractIntegerEnumType extends AbstractEnumType
     /**
      * {@inheritdoc}
      */
-    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
+    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
     {
         return $platform->getIntegerTypeDeclarationSQL($fieldDeclaration);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getBindingType()
+    public function getBindingType(): int
     {
         return \PDO::PARAM_INT;
     }

src/Bridge/Doctrine/DBAL/Types/AbstractJsonCollectionEnumType.php

@@ -16,6 +16,9 @@
 
 abstract class AbstractJsonCollectionEnumType extends JsonType
 {
+    /**
+     * @return mixed
+     */
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
     {
         if (\is_array($value)) {
@@ -27,6 +30,9 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform)
         return parent::convertToDatabaseValue($value, $platform);
     }
 
+    /**
+     * @return mixed
+     */
     public function convertToPHPValue($value, AbstractPlatform $platform)
     {
         $values = parent::convertToPHPValue($value, $platform);
@@ -41,7 +47,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
     /**
      * {@inheritdoc}
      */
-    public function requiresSQLCommentHint(AbstractPlatform $platform)
+    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
     {
         return true;
     }

src/Bridge/Doctrine/ODM/Types/AbstractCollectionEnumType.php

@@ -21,6 +21,9 @@ abstract class AbstractCollectionEnumType extends CollectionType
 {
     use ClosureToPHP;
 
+    /**
+     * @return mixed
+     */
     public function convertToDatabaseValue($value)
     {
         if (\is_array($value)) {
@@ -36,6 +39,8 @@ public function convertToDatabaseValue($value)
      * {@inheritdoc}
      *
      * @psalm-return array<TEnum>|null
+     *
+     * @return mixed
      */
     public function convertToPHPValue($value)
     {

src/Bridge/Doctrine/ODM/Types/AbstractEnumType.php

@@ -23,6 +23,8 @@ abstract class AbstractEnumType extends Type
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function convertToDatabaseValue($value)
     {

src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -20,7 +20,7 @@
 
 class Configuration implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('elao_enum');
         $rootNode = method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('elao_enum');

src/Bridge/Symfony/Bundle/DependencyInjection/ElaoEnumExtension.php

@@ -103,12 +103,12 @@ public function load(array $configs, ContainerBuilder $container)
         ;
     }
 
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return 'http://elao.com/schema/dic/elao_enum';
     }
 
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
     {
         return __DIR__ . '/../Resources/config/schema';
     }

src/Bridge/Symfony/Console/Command/DumpJsEnumsCommand.php

@@ -53,7 +53,7 @@ protected function configure()
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 

src/Bridge/Symfony/Form/Type/EnumType.php

@@ -20,6 +20,9 @@
 use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final
+ */
 class EnumType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
@@ -102,7 +105,7 @@ public function configureOptions(OptionsResolver $resolver)
     /**
      * {@inheritdoc}
      */
-    public function getParent()
+    public function getParent(): ?string
     {
         return ChoiceType::class;
     }

src/Bridge/Symfony/Form/Type/FlaggedEnumType.php

@@ -18,6 +18,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final
+ */
 class FlaggedEnumType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
@@ -53,7 +56,7 @@ public function configureOptions(OptionsResolver $resolver)
     /**
      * {@inheritdoc}
      */
-    public function getParent()
+    public function getParent(): ?string
     {
         return EnumType::class;
     }

src/Bridge/Symfony/HttpKernel/Controller/ArgumentResolver/EnumValueResolver.php

@@ -16,20 +16,23 @@
 use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
+/**
+ * @final
+ */
 class EnumValueResolver implements ArgumentValueResolverInterface
 {
     /**
      * {@inheritdoc}
      */
-    public function supports(Request $request, ArgumentMetadata $argument)
+    public function supports(Request $request, ArgumentMetadata $argument): bool
     {
         return is_subclass_of($argument->getType(), EnumInterface::class);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function resolve(Request $request, ArgumentMetadata $argument)
+    public function resolve(Request $request, ArgumentMetadata $argument): iterable
     {
         /** @var EnumInterface $enumClass */
         $enumClass = $argument->getType();

src/Bridge/Symfony/Serializer/Normalizer/EnumNormalizer.php

@@ -16,30 +16,33 @@
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 
+/**
+ * @final
+ */
 class EnumNormalizer implements NormalizerInterface, DenormalizerInterface
 {
     /**
      * {@inheritdoc}
      *
      * @param EnumInterface $object
      */
-    public function normalize($object, $format = null, array $context = [])
+    public function normalize($object, $format = null, array $context = []): string
     {
         return $object->getValue();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsNormalization($data, $format = null)
+    public function supportsNormalization($data, $format = null): bool
     {
         return $data instanceof EnumInterface;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function denormalize($data, $class, $format = null, array $context = [])
+    public function denormalize($data, $class, $format = null, array $context = []): EnumInterface
     {
         try {
             return \call_user_func([$class, 'get'], $data);
@@ -51,7 +54,7 @@ public function denormalize($data, $class, $format = null, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsDenormalization($data, $type, $format = null)
+    public function supportsDenormalization($data, $type, $format = null): bool
     {
         return is_a($type, EnumInterface::class, true);
     }

src/Bridge/Symfony/Validator/Constraint/Enum.php

@@ -107,6 +107,8 @@ public function __construct(
 
     /**
      * {@inheritdoc}
+     *
+     * @return string
      */
     public function validatedBy()
     {
@@ -116,13 +118,15 @@ public function validatedBy()
     /**
      * {@inheritdoc}
      */
-    public function getDefaultOption()
+    public function getDefaultOption(): ?string
     {
         return 'class';
     }
 
     /**
      * {@inheritdoc}
+     *
+     * @return string[]
      */
     public function getRequiredOptions()
     {

src/Bridge/Twig/Extension/EnumExtension.php

@@ -18,7 +18,10 @@
 
 class EnumExtension extends AbstractExtension
 {
-    public function getFunctions()
+    /**
+     * {@inheritdoc}
+     */
+    public function getFunctions(): array
     {
         return [
             new TwigFunction('enum_get', [$this, 'get']),

src/Enum.php

@@ -159,6 +159,7 @@ public function is($value): bool
     /**
      * @return T
      */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->getValue();

tests/Fixtures/Bridge/Doctrine/DBAL/Types/GenderEnumType.php

@@ -32,7 +32,7 @@ protected function onNullFromPhp()
         return Gender::UNKNOW;
     }
 
-    public function getName()
+    public function getName(): string
     {
         return self::NAME;
     }