Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5.4 deprecs & types #156

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fix 5.4 deprecs & types #156

merged 1 commit into from
Oct 26, 2021

Conversation

ogizanagi
Copy link
Member

I think we should be safe for allowing Symfony 6 without major BC breaks, so we may just release a minor version.
The main impact is on DBAL types for which some types are added on methods, but these are not likely to be overwritten in the context, nor it'll be a big BC on userland.

If it comes to be an issue, we could still conditionally declare the classes according to the detected return types in base ones.


refs:

@ogizanagi ogizanagi requested a review from benji07 October 26, 2021 09:30
Copy link
Contributor

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for a minor

@ogizanagi ogizanagi merged commit ed782a9 into master Oct 26, 2021
@ogizanagi ogizanagi deleted the 54-deprecs branch October 26, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants