Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bw): add missing UA characters, mapping #4823

Merged
merged 4 commits into from
Mar 30, 2024
Merged

fix(bw): add missing UA characters, mapping #4823

merged 4 commits into from
Mar 30, 2024

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Mar 29, 2024

This reworks the support for UA:

  • only add necessary chars and use substitution for chars having a latin equivalent
  • match all UA fonts
  • automatically disables PXX2 for low flash radio so that UA can build

Thanks to the contributions of Salo, Безлактозний Мармелад on EdgeTX discord translation channel

Requires the awesome work by Philmoz in #4816

@raphaelcoeffic
Copy link
Member

Should be rebased once #4816 has been merged.

@philmoz
Copy link
Collaborator

philmoz commented Mar 29, 2024

You might be able to save a few bytes of FLASH by changing the lookup tables in utf8.cpp from wchar_t to uint16_t.

@pfeerick pfeerick added bug 🪲 Something isn't working needs: rebase A git rebase on top of the latest destination branch version is required B&W Related generally to black and white LCD radios translation labels Mar 30, 2024
@pfeerick pfeerick added this to the 2.10 milestone Mar 30, 2024
@pfeerick pfeerick changed the title UA language support fix(bw): UA language support Mar 30, 2024
@pfeerick pfeerick changed the title fix(bw): UA language support fix(bw): add missing UA characters, mapping Mar 30, 2024
@raphaelcoeffic raphaelcoeffic removed the needs: rebase A git rebase on top of the latest destination branch version is required label Mar 30, 2024
@3djc
Copy link
Collaborator Author

3djc commented Mar 30, 2024

You might be able to save a few bytes of FLASH by changing the lookup tables in utf8.cpp from wchar_t to uint16_t.

Saves around 200 on a UA firmware :)

@pfeerick pfeerick merged commit 46f484e into main Mar 30, 2024
44 checks passed
@pfeerick pfeerick deleted the 3djc/bw-ua-rework branch March 30, 2024 21:34
pfeerick added a commit that referenced this pull request Mar 31, 2024
@pfeerick
chore: remove no longer necessary PXX2 OFF
41c5abd 
Workaround introduced in #4823 for UA no longer needed.
pfeerick pushed a commit that referenced this pull request Mar 31, 2024
@3djc @pfeerick
fix(bw): add missing UA characters, mapping (#4823)
771884b
@pfeerick pfeerick mentioned this pull request Apr 1, 2024
Closed
ThomasKuehne pushed a commit to ThomasKuehne/edgetx that referenced this pull request Apr 5, 2024
@3djc @ThomasKuehne
fix(bw): add missing UA characters, mapping (EdgeTX#4823)
22b1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick left review comments

Assignees
No one assigned
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working translation
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
4 participants
@3djc @raphaelcoeffic @philmoz @pfeerick