fix(bw): language special characters not working for 10x14 font size #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
changed the title
pfeerick
added
translation
bug/regression ↩️
|
Updated with a description of the B&W font mappings. |
|
Added some constants to replace the magic numbers to (hopefully) make the code easier to maintain. |
3djc
approved these changes
Mar 29, 2024
|
Works wonder on UA work, so I guess it will work for anything :) |
pfeerick
approved these changes
Mar 30, 2024
pfeerick
pushed a commit
that referenced
this pull request
Mar 30, 2024
…4816) Also cleans up the font handling to make the different font sizes more consistent. It will now allow more than 64 special characters for language translation (if it is ever required).
ThomasKuehne
pushed a commit
to ThomasKuehne/edgetx
that referenced
this pull request
Apr 5, 2024
…dgeTX#4816) Also cleans up the font handling to make the different font sizes more consistent. It will now allow more than 64 special characters for language translation (if it is ever required).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in PR #4806 for handling language special characters in the B&W fonts did not work correctly for the 10x14 font.
This PR fixes that and cleans up the font handling to make the different font sizes more consistent.
It will now allow more than 64 special characters for language translation (if it is ever required).
It also fixes the STR_CHAR_UP and STR_CHAR_DOWN display on 128x64 size screens for the 4x6, 8x10 and 10x14 font sizes.