fix: revert Zorro default contrast #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the Zorro is generally worse at displaying this than the other radios, sure (and mine is, btw). Or would it be better to do this check at around ln 1455 - #if defined(GUI) && !defined(COLORLCD)
if (radioSettingsValid)
lcdSetContrast();
#endif |
pfeerick
added
bug 🪲
pfeerick
pushed a commit
that referenced
this pull request
Jul 23, 2023
…3831) * fix: revert Zorro default contrast * fix: set contrast as soon as radio data is read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a change introduced in #3575
With settings introduced in 3575, author custom splash with a lot of black pixels looks better, but default EdgeTX and many other look worse. Suggesting reverting to initial value
This fixes #3830
Recommend applying to 2.9