radiomaster zorro spash screen bug

[LexFPV]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

i just updated to edgetx 2.9.0 rc1 and im having an issue with the splash screen.

when i power on and the edgetx logo is shown it looks like it tries to put a black background onto the screen while its white
(see screenshots)

this did not happen when i was on 2.8.4.!

Expected Behavior

that it boots up normally without the black backdrop.

Steps To Reproduce

power radio on and look at the splash screen

Version

2.9.0

Transmitter

Radiomaster Zorro

Operating System (OS)

Windows

OS Version

Windows 11, version 22H2

Anything else?

No response

[pfeerick]

Check your contrast setting (SYS -> Radio Setup -> Contrast), it's probably a fraction too high.

[3djc]

Pfeerick is completely right, but I must add that there is no settings that will make it right for all screen. If it is perfect for this one, it will be worse in others. This is not a software issue, it is down to the lcd panel built in power driver circuit (and there I must also add that is is not a Radiomaster issue, all similar radio, including FrSky x7 suffer the very same issue)

[LexFPV]

Pfeerick is completely right, but I must add that there is no settings that will make it right for all screen. If it is perfect for this one, it will be worse in others. This is not a software issue, it is down to the lcd panel built in power driver circuit (and there I must also add that is is not a Radiomaster issue, all similar radio, including FrSky x7 suffer the very same issue)

yeah okay. the thing is that even on contrast level 10 it is still there. and it wasnt there before i updated to 2.9.0(was on 2.8.4 before)

[3djc]

In addition I checked lcd_driver_spi.cpp where this is happening, there no change between 2.8 and 2.9 branches

[LexFPV]

In addition I checked lcd_driver_spi.cpp where this is happening, there no change between 2.8 and 2.9 branches

huh.. so this is just the lcd?

[3djc]

No you are right, there seems to be a difference, trying to narrow it down

[LexFPV]

No you are right, there seems to be a difference, trying to narrow it down

okay.!

[3djc]

Got it, submitting fix PR

[3djc]

As a side note @pfeerick , boot logo is displayed before radio data is loaded so using LCD_CONTRAST_DEFAULT

[pfeerick]

No, that's not quite true... otherwise, the radio wouldn't know to apply the startup delay, or how long to show the logo (if at all). There is a pre-load of the settings to get those values (which is allowed to fail), before choosing to run the animation / show splash screen.

edgetx/radio/src/opentx.cpp

Lines 1445 to 1467 in 2ab21da

	#if defined(STARTUP_ANIMATION)
	lcdRefreshWait();
	lcdClear();
	lcdRefresh();
	lcdRefreshWait();
	bool radioSettingsValid = storageReadRadioSettings(false);
	(void)radioSettingsValid;
	#endif
	BACKLIGHT_ENABLE(); // we start the backlight during the startup animation
	#if defined(STARTUP_ANIMATION)
	if (WAS_RESET_BY_WATCHDOG_OR_SOFTWARE()) {
	pwrOn();
	}
	else {
	runStartupAnimation();
	}
	#else // defined(PWR_BUTTON_PRESS)
	pwrOn();
	haptic.play(15, 3, PLAY_NOW);
	#endif

I think the issue now is that lcdSetContrast isn't called again after board initalisation using LCD_CONTRAST_DEFAULT until later in startup.

edgetx/radio/src/opentx.cpp

Lines 1591 to 1593 in 2ab21da

	#if defined(GUI) && !defined(COLORLCD)
	lcdSetContrast();
	#endif