-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(color): Scroll order for 'FlySky' module options #3479
Conversation
Fix simulator crash issues related to FlySky module.
27a58f5
to
1c01601
Compare
@pfeerick This need to be merge in 2.8.3 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on NV14 and TX16S, squash merge when ready @richardclli (just double check the commit message before merging as GitHub has a habit of not using the PR title).
The implementation has some problems. Need to figure out how the options sync, there are a few observations in the code:
So the problem is:
I think it is better to work more about this in 2.9 and leave 2.8.3 as is. @pfeerick |
Sounds good to me, given these are issues outside of the scope of this PR. I believe some options may needto be saved in yaml, but the rest are sourced from the module since they are determined by which receiver id is active - it's a matter of determining the balance, and making sure they stay in sync. One think to bear in mind is that if all the settings are saved to the yaml, this allows the simulator to better reflect the radio config ;) For point 3 - you really need to ask Flysky if it is a bind time or runtime option, then we can work forward from that. |
Point 3, I think it is a runtime options, but I will work with Flysky to ensure the correctness. |
Fixes #3477
Also fix simulator crash issues related to FlySky module.