Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): Scroll order for 'FlySky' module options #3479

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 15, 2023

Fixes #3477

Also fix simulator crash issues related to FlySky module.

@pfeerick pfeerick added this to the 2.9 milestone Apr 15, 2023
Fix simulator crash issues related to FlySky module.
@philmoz philmoz force-pushed the flysky-module-options-order branch from 27a58f5 to 1c01601 Compare April 16, 2023 00:31
@richardclli
Copy link
Collaborator

@pfeerick This need to be merge in 2.8.3 as well.

@pfeerick pfeerick added color Related generally to color LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Apr 16, 2023
@pfeerick pfeerick modified the milestones: 2.9, 2.8.3 Apr 16, 2023
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on NV14 and TX16S, squash merge when ready @richardclli (just double check the commit message before merging as GitHub has a habit of not using the PR title).

@pfeerick pfeerick changed the title fix(color) - Fix scroll order for module options when 'FlySky' module type selected. fix(color): Scroll order for 'FlySky' module options Apr 17, 2023
@richardclli
Copy link
Collaborator

richardclli commented Apr 17, 2023

The implementation has some problems. Need to figure out how the options sync, there are a few observations in the code:

  1. Some options are saved in yml

         emi: 2
         telemetry: 1
         phyMode: 3
         reserved: 0
    
  2. These options will be updated when parsing AFHDS3 data in afhds3.cpp

     moduleData->afhds3.emi = cfg.v0.EMIStandard;
     moduleData->afhds3.telemetry = cfg.v0.IsTwoWay;
     moduleData->afhds3.phyMode = cfg.v0.PhyMode;
    

So the problem is:

  1. Are these information better not saved to yml? Or the yml need to be updated once these options are read?
  2. How can the UI reflect the change of these options?
  3. Current the options can only be changed in bind. Can the UI trigger changes and send back to the module on the fly?

I think it is better to work more about this in 2.9 and leave 2.8.3 as is. @pfeerick

@richardclli richardclli modified the milestones: 2.8.3, 2.9 Apr 17, 2023
@pfeerick
Copy link
Member

Sounds good to me, given these are issues outside of the scope of this PR.

I believe some options may needto be saved in yaml, but the rest are sourced from the module since they are determined by which receiver id is active - it's a matter of determining the balance, and making sure they stay in sync. One think to bear in mind is that if all the settings are saved to the yaml, this allows the simulator to better reflect the radio config ;)

For point 3 - you really need to ask Flysky if it is a bind time or runtime option, then we can work forward from that.

@pfeerick pfeerick merged commit 54e0d35 into EdgeTX:main Apr 18, 2023
@richardclli
Copy link
Collaborator

Sounds good to me, given these are issues outside of the scope of this PR.

I believe some options may needto be saved in yaml, but the rest are sourced from the module since they are determined by which receiver id is active - it's a matter of determining the balance, and making sure they stay in sync. One think to bear in mind is that if all the settings are saved to the yaml, this allows the simulator to better reflect the radio config ;)

For point 3 - you really need to ask Flysky if it is a bind time or runtime option, then we can work forward from that.

Point 3, I think it is a runtime options, but I will work with Flysky to ensure the correctness.

pfeerick added a commit that referenced this pull request Apr 19, 2023
@philmoz philmoz deleted the flysky-module-options-order branch October 23, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tx16S Use Roller to Setup FRM303, UI components not follow the order of display
3 participants