Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx16S Use Roller to Setup FRM303, UI components not follow the order of display #3477

Closed
1 task done
richardclli opened this issue Apr 14, 2023 · 3 comments · Fixed by #3479 or #3501
Closed
1 task done

Tx16S Use Roller to Setup FRM303, UI components not follow the order of display #3477

richardclli opened this issue Apr 14, 2023 · 3 comments · Fixed by #3479 or #3501
Labels
bug 🪲 Something isn't working
Milestone

Comments

@richardclli
Copy link
Collaborator

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

External RF Setuo, when setting up the FRM303, hard to address the type using the roller:

Mode: FLYSKY -> AFHDS3 ->Channel Range CH1 (skipped the type fields) ->CH18 ->Failsafe mode -> Receiver ID -> bind -> Type (wrong order) .....

Expected Behavior

Mode: FLYSKY -> AFHDS3 ->Type -> Module Options -> Channel Range CH1 ->CH18 ->Failsafe mode -> Receiver ID -> bind

Steps To Reproduce

  1. Model Settings
  2. External RF
  3. Walk with roller to different fields

Version

2.8.2

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

@richardclli richardclli added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Apr 14, 2023
@philmoz
Copy link
Collaborator

philmoz commented Apr 14, 2023

The FlySkySettings class deletes and re-creates all the controls in the module options section (between Mode and Channel Range). This causes the order of the controls on the page to change when scrolling.

It needs to be rewritten to show/hide the controls instead.

I can look at this in the next couple of days if no one else is fixing it.

I also noticed that pressing the 'Module options' will crash the simulator.

@richardclli
Copy link
Collaborator Author

The FlySkySettings class deletes and re-creates all the controls in the module options section (between Mode and Channel Range). This causes the order of the controls on the page to change when scrolling.

It needs to be rewritten to show/hide the controls instead.

I can look at this in the next couple of days if no one else is fixing it.

I also noticed that pressing the 'Module options' will crash the simulator.

Yes, please help to check. Module options is updated by Flysky to bring setup features for PWM output for each channel. You can check this PR to see what they have changed. #3443

@richardclli richardclli removed the triage Bug report awaiting review / sorting label May 5, 2023
@richardclli
Copy link
Collaborator Author

Reverted the PR, will work out the fix again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
2 participants