Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(color) - Implement DISPLAY_TRIMS_CHANGE option for color LCD trim widget. #3288

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat(color) - Implement DISPLAY_TRIMS_CHANGE option for color LCD trim widget. #3288

merged 3 commits into from
Mar 14, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Mar 1, 2023

Also refactor trim code.

@Eldenroot
Copy link
Contributor

Does it fix this one?
#2050

@philmoz
Copy link
Collaborator Author

philmoz commented Mar 2, 2023

Does it fix this one?
#2050

Yes, although I'm not happy with the way the trim value is displayed.
It does not fit properly in the trim box for large and negative values.
I am experimenting with displaying it the way B&W radios do.

@Eldenroot
Copy link
Contributor

Good, thank you.

It could be enhanced in future :)

@philmoz
Copy link
Collaborator Author

philmoz commented Mar 2, 2023

I've changed the display to work like B&W radios with the trim value to the side instead of over the position marker.

Screen Shot 2023-03-03 at 9 59 10 am

@pfeerick pfeerick added this to the 2.9 milestone Mar 13, 2023
@pfeerick pfeerick added enhancement ✨ New feature or request color Related generally to color LCD radios labels Mar 14, 2023
@pfeerick pfeerick linked an issue Mar 14, 2023 that may be closed by this pull request
Number in trim bar (on change) #2050
Closed
1 task
@pfeerick
Copy link
Member

This looks great, and B&W consistency is a nice touch (as well as good inspiration at times).

@pfeerick pfeerick merged commit 667cc84 into EdgeTX:main Mar 14, 2023
@philmoz philmoz deleted the display-trims-change branch September 20, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Number in trim bar (on change)
3 participants
@philmoz @Eldenroot @pfeerick