Number in trim bar (on change)

[Eldenroot]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Select "change" option in "show number in trim bar" in MDL setup

(I use the Czech language, not sure if the translation is correct)

Try to change trims - no number is displayed on change... it is displayed only if you select "Yes" in the settings.

Expected Behavior

Value should be visible

Steps To Reproduce

Select "change" option in "show number in trim bar" in MDL setup

(I use the Czech language, not sure if the translation is correct)

Try to change trims - no number is displayed on change... it is displayed only if you select "Yes" in the settings.

Version

2.7.1

Transmitter

Radiomaster TX16S

Anything else?

No response

[robertjmcintyre]

I've repro'd this on an x10S, running 2.7.1, running English language. It looks like:

• Display Trims = No : works as expected
• Display Trims = Yes : works as expected
• Display Trims = Change : seems to work the same as "No"

[pfeerick]

This is also the case with yesterdays nightly on TX16S, which is the more important version to test right now as a lot of the UI code has been redone due to LVGL.

Relevant code is here... and note the TODO ;)

This is a colorlcd only issue - B&W UI is still fine.

edgetx/radio/src/gui/colorlcd/layouts/trims.cpp

Lines 98 to 111 in ce8cc0b

	// Trim value / small lines on the square
	if (g_model.displayTrims == DISPLAY_TRIMS_ALWAYS) {
	// TODO DISPLAY_TRIMS_CHANGE
	dc->drawNumber(x + (TRIM_SQUARE_SIZE + 1) / 2, 3,
	divRoundClosest(value * 100, trimMax),
	FONT(XXS) | COLOR_THEME_PRIMARY2 | CENTERED);
	} else {
	if (value >= 0) {
	dc->drawSolidVerticalLine(x + 4, 3, 9, COLOR_THEME_PRIMARY2);
	}
	if (value <= 0) {
	dc->drawSolidVerticalLine(x + 10, 3, 9, COLOR_THEME_PRIMARY2);
	}
	}

[robertjmcintyre]

Apologies if this is considered a "rude" question, but what's the user scenario for this feature (only temporarily displaying the value after a change)? I'm having trouble imagining a situation where I care about the number but only for a short while after a change, and after that it would bother me to have it displayed. I get when I may want to know the actual number, and I get that most of the time I might not care about the number. I don't see the middle ground though.

@pfeerick , you added a B&W tag, did you mean to add color instead (on simulator the B&W seems to work as expected)?

This is also the case with yesterdays nightly on TX16S, which is the more important version to test right now as a lot of the UI code has been redone due to LVGL.

My X10S is my only radio, and I've not updated it to the mainline builds yet. :) I'm saving my pennies to buy a TX16S II, though, and can then have a test radio.

[pfeerick]

I have no idea what you're talking about... it says color 😁 Thanks ;)

I think is like best of both... you can see the position all the time, and the number pops up on change for about two seconds if for some reason you need to sometimes know the value. On OTX it's like ETX B&W, the number is to the side of the knob... but that part isn't too important...

[robertjmcintyre]

Oh, I get how it works, I just don’t understand the “why” of the scenario. What’s an example where it would be useful for it to only show up for a few seconds, then go away?

[raphaelcoeffic]

I was wondering as well…

[Eldenroot]

Still valid, maybe lets discuss if there is a better way how to implement?