-
-
Notifications
You must be signed in to change notification settings - Fork 62.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add react js into js section #6079
Merged
eshellman
merged 4 commits into
EbookFoundation:master
from
MohammadHosseinBagheri:fa-reactjs-book
Nov 10, 2021
Merged
add react js into js section #6079
eshellman
merged 4 commits into
EbookFoundation:master
from
MohammadHosseinBagheri:fa-reactjs-book
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorpa
requested changes
Oct 8, 2021
davorpa
added
waiting for changes
PR has been reviewed and changes/suggestions requested
linter error
Please, correct build errors found by linter!
labels
Oct 8, 2021
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
davorpa
added
the
stale
Requests that have not had recent interaction (Out-of-Date)
label
Nov 1, 2021
davorpa
reviewed
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohammadHosseinBagheri, @armanabkar could you help us with alphabetization? I can't deal with Persian
Run fpb-lint ./books/
books/free-programming-books-fa_IR.md
45:1-47:84 warning Alphabetical ordering: swap L.47 and L.46 alphabetize-lists remark-lint
⚠ 1 warning
Error: Process completed with exit code 1.
A continue intent: #6079. @armanabkar feel free to suggest changes here, in those lines you think be convenient
davorpa
reviewed
Nov 9, 2021
davorpa
removed
waiting for changes
PR has been reviewed and changes/suggestions requested
help wanted
Needs help solving a blocked / stucked item
linter error
Please, correct build errors found by linter!
labels
Nov 9, 2021
davorpa
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚀 ready to merge
LGTM. Waiting for final approval
stale
Requests that have not had recent interaction (Out-of-Date)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add resource(s)
For resources
Description
React js doc in persian
Why is this valuable (or not)?
because it is very simple to use for Persian people that works with react
How do we know it's really free?
Github Repo
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up