Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react js into js section #6079

Merged

Conversation

MohammadHosseinBagheri
Copy link
Contributor

What does this PR do?

Add resource(s)

For resources

Description

React js doc in persian

Why is this valuable (or not)?

because it is very simple to use for Persian people that works with react

How do we know it's really free?

Github Repo

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

books/free-programming-books-fa_IR.md Outdated Show resolved Hide resolved
@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested linter error Please, correct build errors found by linter! labels Oct 8, 2021
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa davorpa self-assigned this Oct 16, 2021
@davorpa davorpa self-requested a review November 1, 2021 22:11
@davorpa davorpa added the stale Requests that have not had recent interaction (Out-of-Date) label Nov 1, 2021
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohammadHosseinBagheri, @armanabkar could you help us with alphabetization? I can't deal with Persian

Run fpb-lint ./books/
books/free-programming-books-fa_IR.md
  45:1-47:84  warning  Alphabetical ordering: swap L.47 and L.46  alphabetize-lists  remark-lint

⚠ 1 warning
Error: Process completed with exit code 1.

A continue intent: #6079. @armanabkar feel free to suggest changes here, in those lines you think be convenient

@davorpa davorpa added the help wanted Needs help solving a blocked / stucked item label Nov 2, 2021
@davorpa davorpa removed waiting for changes PR has been reviewed and changes/suggestions requested help wanted Needs help solving a blocked / stucked item linter error Please, correct build errors found by linter! labels Nov 9, 2021
@davorpa davorpa self-requested a review November 9, 2021 22:05
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Nov 9, 2021
@eshellman eshellman merged commit 78d04a4 into EbookFoundation:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval stale Requests that have not had recent interaction (Out-of-Date)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants