Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react js fa repo #6048

Conversation

MohammadHosseinBagheri
Copy link
Contributor

@MohammadHosseinBagheri MohammadHosseinBagheri commented Oct 8, 2021

What does this PR do?

Add resource | Improve repo

For resources

Description

React js library in the Persian language

Why is this valuable (or not)?

Because that is a JavaScript library for building user interfaces and it has many Persian developers so it helps them

How do we know it's really free?

React is an open-source library and it is a
Github repository

For book lists, is it a book? For course lists, is it a course? etc.

it's a course

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

Why the repo instead of the website?
React resources should go in the Javascript section untill there are enough resource to make a subsection.

@eshellman eshellman added question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 8, 2021
@davorpa davorpa mentioned this pull request Oct 8, 2021
5 tasks
@MohammadHosseinBagheri
Copy link
Contributor Author

Why the repo instead of the website? React resources should go in the Javascript section untill there are enough resource to make a subsection.
@eshellman because we need other Persian to complete this repo and help us too making better react doc in persian

@eshellman
Copy link
Collaborator

put the resource in the javascript section

@MohammadHosseinBagheri
Copy link
Contributor Author

put the resource in the javascript section

I did it

@davorpa
Copy link
Member

davorpa commented Oct 8, 2021

put the resource in the javascript section

I did it

Maybe forget make the push? PR is auto-synchronized when a push over same branch of your fork is made

@davorpa davorpa closed this Oct 8, 2021
@davorpa davorpa added duplicate Contributed resource, issue, pull request... already exists and removed question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 8, 2021
@davorpa davorpa reopened this Oct 8, 2021
@davorpa
Copy link
Member

davorpa commented Oct 8, 2021

Closing in favour of ##6079, where continues the work

Duplicate of #6079

@davorpa davorpa closed this Oct 8, 2021
@davorpa davorpa self-assigned this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Contributed resource, issue, pull request... already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants